Re: [PATCH 1/4] dt-bindings: input: touchscreen: hynitron,cst816x: configure axes
From: Conor Dooley
Date: Thu Oct 01 2026 - 15:04:09 EST
On Thu, Oct 01, 2026 at 11:52:31AM +0100, Daniel Golle wrote:
> Reference touchscreen.yaml and allow properties
> 'touchscreen-inverted-x', 'touchscreen-inverted-y' and
> 'touchscreen-swapped-x-y'.
This is a useless commit message, it just says what the diff does.
Please provide a justification for why this is the right thing to do.
pw-bot: changes-requested
>
> Signed-off-by: Daniel Golle <daniel@xxxxxxxxxxxxxx>
> ---
> .../bindings/input/touchscreen/hynitron,cst816x.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/hynitron,cst816x.yaml b/Documentation/devicetree/bindings/input/touchscreen/hynitron,cst816x.yaml
> index 72d4da636881e..ba56bf61038c5 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/hynitron,cst816x.yaml
> +++ b/Documentation/devicetree/bindings/input/touchscreen/hynitron,cst816x.yaml
> @@ -36,6 +36,10 @@ properties:
> - description: Slide right gesture
> - description: Long press gesture
>
> + touchscreen-inverted-x: true
> + touchscreen-inverted-y: true
> + touchscreen-swapped-x-y: true
> +
> required:
> - compatible
> - reg
> @@ -43,6 +47,9 @@ required:
>
> additionalProperties: false
>
> +allOf:
> + - $ref: touchscreen.yaml#
> +
> examples:
> - |
> #include <dt-bindings/gpio/gpio.h>
> @@ -59,6 +66,7 @@ examples:
> reset-gpios = <&gpio 17 GPIO_ACTIVE_LOW>;
> linux,keycodes = <KEY_UP>, <KEY_DOWN>, <KEY_LEFT>, <KEY_RIGHT>,
> <BTN_TOOL_TRIPLETAP>;
> + touchscreen-swapped-x-y;
> };
> };
>
> --
> 2.55.0
Attachment:
signature.asc
Description: PGP signature