Re: [PATCH] slimbus: qcom-ngd-ctrl: Release the TX descriptor on error paths

[Greg Kroah-Hartman]

On Thu, Oct 01, 2026 at 11:25:20PM +0000, Babanpreet Singh wrote:
> Hi Srinivas,
> 
> Static analysis, then reading. smatch flagged the txn->msg check in
> qcom_slim_ngd_xfer_msg() and while I was looking at that function I
> noticed the two returns between tx_msg_get() and tx_msg_post(). I do not
> have a SLIMbus target. The -ENOMEM consequence in the commit message is
> derived from the code rather than observed: tx_head only moves in
> qcom_slim_ngd_tx_msg_dma_cb() and in the re-init path, so a descriptor
> that is claimed and never posted has no way back into the ring.
> 
> Verification was build only.
> 
> On the stable tag: I can send a v2 with Cc: stable and the "found by
> static analysis, compile tested only" wording.

We have no context here at all, please never top-post, as my bot says:


A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top