Re: [PATCH] rust: bitfield: remove unnecessary `#[allow]`

From: Miguel Ojeda

Date: Fri Oct 02 2026 - 03:08:52 EST


On Thu, Sep 10, 2026 at 7:05 PM Gary Guo <gary@xxxxxxxxxx> wrote:
>
> From: Gary Guo <gary@xxxxxxxxxxx>
>
> The `#[allow(non_camel_case_types)]` was there because register names can
> be commonly SCREAMING_CASE and thus not CamelCase. However, when a bitfield
> type is created by itself, this justification does not apply. Thus, remove
> it.
>
> Users that want to use non-standard styles can add the `#[allow]`
> themselves. For example, the invocation of `bitfield!` inside `register!`
> macro carry this annotation.
>
> Signed-off-by: Gary Guo <gary@xxxxxxxxxxx>

Applied to `rust-next` -- thanks everyone!

Cheers,
Miguel