Re: [PATCH v7 02/16] media: ov8858: support 19.2 MHz clock and CHT gain setup
From: Andy Shevchenko
Date: Fri Oct 02 2026 - 03:17:46 EST
On Thu, Oct 01, 2026 at 11:00:35PM +0300, Sakari Ailus wrote:
> On Wed, Sep 02, 2026 at 04:53:31PM +0200, Maurizio Casciano wrote:
...
> > Link: https://lore.kernel.org/linux-media/apf7cJOoXrl_wZfr@kekkonen.localdomain/
Most likely wrong tag. Why is it here? What for?
> > Signed-off-by: Maurizio Casciano <mauriziocasciano7@xxxxxxxxx>
> > Assisted-by: LLM [Codex] [Sparse]
Please, find the correct format of this tag in the documentation.
Should be (if I'm not mistaken)
Assisted-by: LLM sparse
...
> > -#define OV8858_LINK_FREQ 360000000U
> > -#define OV8858_XVCLK_FREQ 24000000
> > +#define OV8858_LINK_FREQ (360 * HZ_PER_MHZ)
> > +#define OV8858_XVCLK_FREQ_24MHZ 24000000
> > +#define OV8858_XVCLK_FREQ_19_2MHZ 19200000
>
> Why to use HZ_PER_MHZ for LINK_FREQ but not the rest?
Because we do not do floats in the kernel. And hence for the consistency's
sake.
--
With Best Regards,
Andy Shevchenko