Re: [PATCH rtw-next v6 4/6] wifi: rtw88: 8723b: add the RTL8723B chip driver

[Luka Gejak]

October 1, 2026 at 22:39, "Bitterblue Smith" <rtl8821cerfe2@xxxxxxxxx mailto:rtl8821cerfe2@xxxxxxxxx?to=%22Bitterblue%20Smith%22%20%3Crtl8821cerfe2%40gmail.com%3E > wrote:


> 
> On 01/10/2026 12:18, Luka Gejak wrote:
> 
> > 
[...]
> >  +static void rtw8723b_sdio_restore_pad_ctrl(struct rtw_dev *rtwdev,
> >  + bool keep_pta_owner)
> >  +{
> >  + u32 before;
> >  + u32 after;
> >  +
> >  + if (!rtw_is_8723bs(rtwdev))
> >  + return;
> >  +
> >  + before = rtw_read32(rtwdev, REG_PAD_CTRL1);
> >  + after = before & ~(BIT_LNAON_WLBT_SEL | BIT_SW_DPDT_SEL_DATA);
> >  + if (keep_pta_owner)
> >  + after |= BIT_PAPE_WLBT_SEL;
> >  + else
> >  + after &= ~BIT_PAPE_WLBT_SEL;
> >  + if (after == before)
> >  + return;
> >  +
> >  + rtw_write32(rtwdev, REG_PAD_CTRL1, after);
> >  +}
> > 
> Is this function still needed if rtw_mac_pre_system_cfg() doesn't
> touch REG_PAD_CTRL1?
> 

Not needed anymore, I missed it. It and its call sites are removed in v7.

> > 
> > +
[...]
> >  +static void rtw8723b_fill_txdesc_checksum(struct rtw_dev *rtwdev,
> >  + struct rtw_tx_pkt_info *pkt_info,
> >  + u8 *txdesc)
> >  +{
> >  + struct rtw_tx_desc *tx_desc = (struct rtw_tx_desc *)txdesc;
> >  + const u8 *data = txdesc;
> >  + int words = 32 / 2;
> >  + u16 checksum = 0;
> >  +
> >  + /* Unlike the shared 8723x helper, the checksum is not inverted here. */
> >  + le32p_replace_bits(&tx_desc->w7, 0, RTW_TX_DESC_W7_TXDESC_CHECKSUM);
> >  +
> >  + while (words--) {
> >  + checksum ^= get_unaligned_le16(data);
> >  + data += sizeof(__le16);
> >  + }
> >  +
> >  + le32p_replace_bits(&tx_desc->w7, checksum,
> >  + RTW_TX_DESC_W7_TXDESC_CHECKSUM);
> > 
> This function can just call fill_txdesc_checksum_common() from tx.h.
> 

Thanks, I didn't catch it. It does call it in v7.

Best regards,
Luka Gejak