Re: [PATCH v7 00/20] crypto: talitos - Driver cleanup

[Herbert Xu]

On Wed, Sep 23, 2026 at 05:18:36PM +0200, Paul Louvel wrote:
>
> Sashiko reviews dismissed:
> 
> [1], 1: If this is an issue, it is an existing issue because
> the driver used devm_kzalloc() to allocate an instance of struct
> talitos_crypto_alg.
> Second, how should a driver knows that it should keep this memory
> because a tfm instance is still alive ? For me, the only fix would be to
> use kzalloc() and then never free it, which is not acceptable.
> 
> [2], [3]: A kernel configuration that selects both version is possible,
> but a SoC featuring both hardware version of the crypto engine is not
> possible and not described in any device tree. Freescale MPCxxxx SoC
> family is more than 15+ years old.

Could you please post responses to the new review comments as well?

https://sashiko.dev/#/patchset/20260923-7-3-rc2_talitos_cleanup-v7-0-9a45261fc097%40bootlin.com

Thanks,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt