Re: [PATCH net-next v9 07/12] gve: add gve_ctrl_ops for gve initialization/teardown sequences

[netdev-bot+sashiko]

Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.

Low priority / nit picks for your consideration:

- [Low] After this patch changes the prototype of
  gve_adminq_get_ptype_map_dqo() from `(struct gve_priv *priv, struct…

--

gve: add gve_ctrl_ops for gve initialization/teardown sequences

This commit adds get_ptype_map, configure_rss, setup_stats_report and
reset_flow_rules callbacks to struct gve_ctrl_ops. The adminq
implementations are wired into gve_adminq_ops, and gve_main.c now calls
these operations through priv->ctrl_ops. gve_adminq_get_ptype_map_dqo()
now writes to priv->ptype_lut_dqo directly instead of taking the lut as a
parameter.

> diff --git a/drivers/net/ethernet/google/gve/gve_adminq.h b/drivers/net/ethernet/google/gve/gve_adminq.h
> index fe1e8868cdfe2..5e51c060e2372 100644
> --- a/drivers/net/ethernet/google/gve/gve_adminq.h
> +++ b/drivers/net/ethernet/google/gve/gve_adminq.h
> @@ -652,8 +652,7 @@ int gve_adminq_report_nic_ts(struct gve_priv *priv,
>  			     dma_addr_t nic_ts_report_addr);
>  
>  struct gve_ptype_lut;
   ^^^^

[Severity: Low]
This isn't a bug, but is this forward declaration still needed?

The removed struct gve_ptype_lut *ptype_lut parameter was the only user
of struct gve_ptype_lut in gve_adminq.h, so the declaration now has no
users. It is also still present at the end of the series, after
"gve: add link status/speed ctrl ops".

Could it be dropped in this patch, along with the parameter?

> -int gve_adminq_get_ptype_map_dqo(struct gve_priv *priv,
> -				 struct gve_ptype_lut *ptype_lut);
> +int gve_adminq_get_ptype_map_dqo(struct gve_priv *priv);
>  int gve_adminq_set_num_ntfy_blks(struct gve_priv *priv);
>  void gve_adminq_set_num_queues(struct gve_priv *priv);
>  int gve_adminq_map_db_bar(struct gve_priv *priv);

[ ... ]

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260930190428.1130007-1-hramamurthy%40google.com