Re: [PATCH v22 09/10] firmware: arm_rmm: Add wrappers for Realm related RMI commands

[Catalin Marinas]

On Fri, Oct 02, 2026 at 07:15:05AM +0100, Suzuki K Poulose wrote:
> +/*
> + * rmi_smccc_invoke_once: Invoke the RMI call and return the results. Do not
> + * retry the command. Let the caller deal with RMI_BUSY or RMI_BLOCKED.
> + *
> + * @regs: Input parameters filled in. Updated with the ouptput results
> + * after the call.
> + */
> +static __always_inline void rmi_smccc_invoke_once(struct arm_smccc_1_2_regs *regs)
> +{
> +	struct arm_smccc_1_2_regs args = *regs;
> +
> +	arm_smccc_1_2_smc(&args, regs);
> +}

Nit: I mentioned on v21 - is the copy to args still needed? Can we not
do just:

	arm_smccc_1_2_smc(regs, regs);

(no need to respin, I can fix it locally)

-- 
Catalin