Re: [PATCH 6.1.y 4/4] fs/ntfs3: fix slab-out-of-bounds write in ni_create_attr_list()

[Sasha Levin]

> [ Backport to 6.1.y: 6.1.y's ni_create_attr_list() uses a `goto out` cleanup
>   convention rather than upstream's early returns, so the new `return` error
>   paths were rewritten as `err = ...; goto out`. ]

[...]

> +	if (!lsize) {
> +		err = -EINVAL;
> +		goto out;
> +	}

On 6.1 the out: label in ni_create_attr_list() is "return 0;", because
14f527d44de6 ("fs/ntfs3: Correct checking while generating attr_list")
isn't in 6.1. So this error path reports success. Please return -EINVAL
directly here, as upstream does.

Could you send a v2 with that fixed? 1/4 also needs its upstream tag,
see my reply there.

-- 
Thanks,
Sasha