Re: [PATCH] pinctrl: starfive: fix missing CONFIG_OF dependencies

[Changhuang Liang]

Hi, Arnd

Thanks for your patch.

> From: Arnd Bergmann <arnd@xxxxxxxx>
> 
> The common driver portion requires CONFIG_OF, but the drivers selecting it
> do not, so we get random warnings:
> 
> WARNING: unmet direct dependencies detected for
> PINCTRL_STARFIVE_JHB100
>   Depends on [n]: PINCTRL [=y] && OF [=n]
>   Selected by [y]:
>   - PINCTRL_STARFIVE_JHB100_PER1 [=y] && PINCTRL [=y] &&
> (ARCH_STARFIVE || COMPILE_TEST [=y])
>   - PINCTRL_STARFIVE_JHB100_PER2POK [=y] && PINCTRL [=y] &&
> (ARCH_STARFIVE || COMPILE_TEST [=y])
>   - PINCTRL_STARFIVE_JHB100_SYS1 [=y] && PINCTRL [=y] &&
> (ARCH_STARFIVE || COMPILE_TEST [=y])
>   Selected by [m]:
>   - PINCTRL_STARFIVE_JHB100_PER0 [=m] && PINCTRL [=y] &&
> (ARCH_STARFIVE || COMPILE_TEST [=y])
>   - PINCTRL_STARFIVE_JHB100_SYS0 [=m] && PINCTRL [=y] &&
> (ARCH_STARFIVE || COMPILE_TEST [=y])
> 
> Apparently the problem is selecting CONFIG_OF_GPIO, which is a mistake the
> newly added driver copied from others. This was recently cleaned up with
> commit e785c990adcc ("pinctrl: Kconfig: drop unneeded dependencies on
> OF_GPIO"). Do the same here for consistency and to avoid the warning.
> 
> Fixes: 9c4d0c8fc4c1 ("pinctrl: starfive: Add StarFive JHB100 sys0 controller
> driver")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Reviewed-by: Changhuang Liang <changhuang.liang@xxxxxxxxxxxxxxxx>

> ---
>  drivers/pinctrl/starfive/Kconfig | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/pinctrl/starfive/Kconfig b/drivers/pinctrl/starfive/Kconfig
> index 11bd429b45b7..7ff506a15dd8 100644
> --- a/drivers/pinctrl/starfive/Kconfig
> +++ b/drivers/pinctrl/starfive/Kconfig
> @@ -50,11 +50,9 @@ config PINCTRL_STARFIVE_JH7110_AON
> 
>  config PINCTRL_STARFIVE_JHB100
>  	bool
> -	depends on OF
>  	select GENERIC_PINCTRL
>  	select GPIOLIB
>  	select GPIOLIB_IRQCHIP
> -	select OF_GPIO
> 
>  config PINCTRL_STARFIVE_JHB100_PER0
>  	tristate "StarFive JHB100 SoC Peripheral-0 pinctrl and GPIO driver"
> --
> 2.53.0

Best Regards
Changhuang