Re: [PATCH] drm/amd/display: fix kernel-doc warnings for cgs register typedefs
From: Omokefe Emmanuel Onanaroghene
Date: Fri Oct 02 2026 - 16:49:42 EST
Hi Christian,
On 10/2/26 13:38, Christian König wrote:
> We should potentially just completely nuke those typedefs since they
> are actually an unnecessarily layer of indirection.
Yes, the cleanup is necessary, but the four comments don't just name the typedefs, they're the only prose describing the operations (MMIO vs indirect access, offset/space/index semantics, return values). Should i relocated onto the struct cgs_ops members or the cgs_read_register macros?
Thanks,
Omokefe