Re: [PATCH] staging: rtl8723bs: Rename CamelCase NDIS encryption state enums

[Marinela Tatiana Selseth]

Hi Greg,

Thank you for the review and the excellent questions.

You are entirely right. These constants are strictly internal software
state values tracked inside 'struct security_priv'. They are used
internally by the driver's connection management loops and are never
compiled into raw packet payloads sent over the air or passed down
directly to the core network stack.

The driver replicates this NDIS layout internally because it was
originally ported from a legacy unified vendor baseline, and the
mainline kernel does not export a generic NDIS encryption status enum
stack for staging items.

Your point is completely taken, the rest of the anonymous enum block
contains similar CamelCase leftovers (e.g., Ndis802_11WEPEnabled,
Ndis802_11WEPKeyAbsent).

While here, can condense the duplicate defines in one, like
NDIS_802_11_ENCRYPTION_DISABLED, and NDIS_802_11_WEP_DISABLED.

Will scale up this work and submit a v2 patch series that converts the
entire enum infrastructure cleanly over to standard uppercase NDIS
snake_case conventions.

Best regards,
Marinela