Re: [PATCH] phy: HiSilicon: Fix error handling in hi3670_pcie_allclk_ctrl()
From: Vinod Koul
Date: Sat Oct 03 2026 - 05:37:43 EST
On Wed, 08 Jul 2026 16:31:00 -0500, Akash Sukhavasi wrote:
> When hi3670_pcie_pll_ctrl() fails, hi3670_pcie_allclk_ctrl() returns
> -EINVAL directly, skipping the close_clocks cleanup path. This leaves
> the PLL with its power-down bit cleared.
>
> Use goto close_clocks instead, which disables the PLL and propagates
> the original error code from hi3670_pcie_pll_ctrl().
>
> [...]
Applied, thanks!
[1/1] phy: HiSilicon: Fix error handling in hi3670_pcie_allclk_ctrl()
commit: 7540fc0a4f667b6773d10753a602a42a3113087b
Best regards,
--
~Vinod