Re: [PATCH v26 06/10] power: reset: Add psci-reboot-mode driver

[Shivendra Pratap]

On 10/2/2026 7:00 PM, Bartosz Golaszewski wrote:
> On Mon, 28 Sep 2026 08:09:18 +0200, Shivendra Pratap
> <shivendra.pratap@xxxxxxxxxxxxxxxx> said:
> > PSCI supports different types of resets like SYSTEM_RESET, SYSTEM_RESET2
> > ARCH WARM reset and SYSTEM_RESET2 vendor-specific resets. Currently
> > there is no common driver that handles all supported psci resets at one
> > place. Additionally, there is no common mechanism to issue the supported
> > psci resets from userspace.
> >
> > Add psci-reboot-mode as an auxiliary device created by the psci-devices
> > driver. Define two types of PSCI resets, predefined-resets and
> > vendor-specific resets. Predefined-resets are defined by psci driver
> > and vendor-specific resets are defined by SoC vendors, under the
> > psci:reboot-mode node of SoC device tree.
> >
> > Register the driver with the reboot-mode framework to interface these
> > resets to userspace. When userspace initiates a supported command, pass
> > the reset arguments to the PSCI driver to enable command-based reset.
> >
> > This change allows userspace to issue supported PSCI reset commands
> > using the standard reboot system calls while enabling SoC vendors to
> > define their specific resets for PSCI.
> >
> > Suggested-by: Ulf Hansson <ulf.hansson@xxxxxxxxxxxxxxxx>
> > Suggested-by: Lee Jones <lee@xxxxxxxxxx>
> > Suggested-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Shivendra Pratap <shivendra.pratap@xxxxxxxxxxxxxxxx>
> > ---
> >   MAINTAINERS                            |   1 +
> >   drivers/firmware/psci/psci-devices.c   |   4 ++
> >   drivers/power/reset/Kconfig            |  11 ++++
> >   drivers/power/reset/Makefile           |   1 +
> >   drivers/power/reset/psci-reboot-mode.c | 104 +++++++++++++++++++++++++++++++++
> >   5 files changed, 121 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 70a11f2ff61d..1007d5cd2e13 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -22058,6 +22058,7 @@ L:	linux-arm-kernel@xxxxxxxxxxxxxxxxxxx (moderated for non-subscribers)
> >   S:	Maintained
> >   F:	Documentation/devicetree/bindings/arm/psci.yaml
> >   F:	drivers/firmware/psci/
> > +F:	drivers/power/reset/psci-reboot-mode.c
> >   F:	include/linux/psci.h
> >   F:	include/uapi/linux/psci.h
> >
> > diff --git a/drivers/firmware/psci/psci-devices.c b/drivers/firmware/psci/psci-devices.c
> > index d23befc490ed..04f24b8d9943 100644
> > --- a/drivers/firmware/psci/psci-devices.c
> > +++ b/drivers/firmware/psci/psci-devices.c
> > @@ -20,6 +20,10 @@ static const struct arm_psci_device_info arm_psci_devices[] = {
> >   	{
> >   		.name = "psci-cpuidle-domain",
> >   	},
> > +	{
> > +		.name = "psci-reboot-mode",
> > +		.of_node_name = "reboot-mode",
> > +	},
> >   };
> >
> >   static void arm_psci_auxiliary_device_release(struct device *dev)
> > diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
> > index bce996bbef28..f165a41d40ed 100644
> > --- a/drivers/power/reset/Kconfig
> > +++ b/drivers/power/reset/Kconfig
> > @@ -360,6 +360,17 @@ config NVMEM_REBOOT_MODE
> >   	  then the bootloader can read it and take different
> >   	  action according to the mode.
> >
> > +config PSCI_REBOOT_MODE
> > +	bool "PSCI reboot mode driver"
> > +	depends on ARM_PSCI_DEVICES
> > +	select AUXILIARY_BUS
> > +	select REBOOT_MODE
> > +	help
> > +	  Say y here to enable the PSCI reboot mode driver. The driver
> > +	  registers with the reboot-mode framework to configure PSCI
> > +	  reset commands, which are executed by the PSCI driver during
> > +	  psci_sys_reset().
> > +
> >   config POWER_MLXBF
> >   	tristate "Mellanox BlueField power handling driver"
> >   	depends on (GPIO_MLXBF2 || GPIO_MLXBF3) && ACPI
> > diff --git a/drivers/power/reset/Makefile b/drivers/power/reset/Makefile
> > index e31cab4ba78e..45d8aaaffaa1 100644
> > --- a/drivers/power/reset/Makefile
> > +++ b/drivers/power/reset/Makefile
> > @@ -41,5 +41,6 @@ obj-$(CONFIG_REBOOT_MODE) += reboot-mode.o
> >   obj-$(CONFIG_SYSCON_REBOOT_MODE) += syscon-reboot-mode.o
> >   obj-$(CONFIG_POWER_RESET_SC27XX) += sc27xx-poweroff.o
> >   obj-$(CONFIG_NVMEM_REBOOT_MODE) += nvmem-reboot-mode.o
> > +obj-$(CONFIG_PSCI_REBOOT_MODE) += psci-reboot-mode.o
> >   obj-$(CONFIG_POWER_MLXBF) += pwr-mlxbf.o
> >   obj-$(CONFIG_POWER_RESET_QEMU_VIRT_CTRL) += qemu-virt-ctrl.o
> > diff --git a/drivers/power/reset/psci-reboot-mode.c b/drivers/power/reset/psci-reboot-mode.c
> > new file mode 100644
> > index 000000000000..bf2dd6626feb
> > --- /dev/null
> > +++ b/drivers/power/reset/psci-reboot-mode.c
> > @@ -0,0 +1,104 @@
> > +// SPDX-License-Identifier: GPL-2.0-only
> > +/*
> > + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> > + */
> > +
> > +#include <linux/array_size.h>
> > +#include <linux/auxiliary_bus.h>
> > +#include <linux/device.h>
> > +#include <linux/errno.h>
> > +#include <linux/init.h>
> > +#include <linux/kconfig.h>
>
> Huh?

Thanks for review! Will remove these.

thanks,
Shivendra