Re: [PATCH v14 1/3] dt-bindings: perf: Add Broadcom Raspberry Pi AXI PMU definition

[Krzysztof Kozlowski]

On Fri, Oct 02, 2026 at 10:57:34AM -0700, Ian Rogers wrote:
> Add device tree bindings for the Broadcom Raspberry Pi AXI PMU block
> found on BCM2835, BCM2711, and BCM2712 SoCs.
> 
> Depending on the SoC and security configuration, these PMUs support
> either direct MMIO access for the System monitor or routing via the
> Raspberry Pi firmware mailbox IPC for the VideoCore VPU monitor.
> 
> Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
> ---

I could not find lore links in your cover letter, changelog is cut (only
v13), so probably we are repeating. Please start using b4 if providing
entire changelog with links is too difficult.

>  .../bindings/perf/brcm,bcm2835-axiperf.yaml   | 71 +++++++++++++++++++
>  1 file changed, 71 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/perf/brcm,bcm2835-axiperf.yaml
> 
> diff --git a/Documentation/devicetree/bindings/perf/brcm,bcm2835-axiperf.yaml b/Documentation/devicetree/bindings/perf/brcm,bcm2835-axiperf.yaml
> new file mode 100644
> index 000000000000..fcffa5fc6c02
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/perf/brcm,bcm2835-axiperf.yaml
> @@ -0,0 +1,71 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/perf/brcm,bcm2835-axiperf.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Broadcom BCM2835/2711/2712 AXI Performance Monitor
> +
> +maintainers:
> +  - Ian Rogers <irogers@xxxxxxxxxx>
> +  - Raspberry Pi Kernel Maintenance <kernel-list@xxxxxxxxxxxxxxx>

Drop

> +
> +description: |
> +  The Broadcom BCM2835 series (including BCM2711 and BCM2712) features hardware
> +  performance monitors on the AXI bus for evaluating memory bandwidth and
> +  system traffic. Depending on the SoC architecture, multiple monitors exist.
> +  The primary monitor evaluates the System fabric, while the secondary monitor
> +  evaluates the VideoCore VPU hardware.
> +
> +  Older silicon generally restricts direct MMIO access to the VPU endpoints,
> +  requiring them to be accessed over the Raspberry Pi firmware mailbox
> +  interface. If the VPU endpoints are memory-mapped, they are supplied as
> +  secondary resources.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - brcm,bcm2835-axiperf
> +      - brcm,bcm2711-axiperf

Why random order? Keep the list properly sorted by name.

> +      - brcm,bcm2712-axiperf
> +
> +  reg:
> +    minItems: 1
> +    items:
> +      - description: System monitor MMIO surface
> +      - description: VPU monitor MMIO surface
> +    description: |
> +      Memory-mapped I/O resource regions for the AXI PMU endpoints.
> +      Typically ordered as System monitor, followed by VPU monitor if directly
> +      mapped.
> +
> +required:
> +  - compatible
> +  - reg
> +
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - brcm,bcm2712-axiperf
> +    then:
> +      properties:
> +        reg:
> +          maxItems: 1

Why brcm,bcm2835-axiperf has flexible number of addresses?

Best regards,
Krzysztof