Re: [PATCH v5 0/3] Lenovo ThinkPad X13s embedded controller support

[Stephan Gerhold]

On Fri, Oct 02, 2026 at 03:42:48PM +0000, Alex Robinson wrote:
> Add Device Tree support for the ThinkPad X13s embedded controller,
> providing keyboard-backlight control and firmware-driven brightness
> notifications. Its event, backlight and power-management interfaces
> differ from the T14s EC and require a separate driver.
> 
> EC wakeup remains disabled by default because lid closure can trigger
> an unwanted wakeup and no selective event mask is known. Other EC event
> mappings remain outside the scope of this series.
> 
> This follows earlier X13s EC work by Konrad Dybcio and Steev Klimaszewski.
> Development was assisted by an LLM, including analysis of the X13s ACPI
> DSDT and review of the implementation.
> 
> [...]
> Testing:
> - Confirmed GPIO103's firmware-inherited pull-up on a ThinkPad X13s using
>   a vanilla kernel with temporary probe-time instrumentation.
> - Verified that all three v5 patches apply in order to Linux v7.3-rc4
>   without the separate PCI workaround and reproduce the current EC
>   source files byte-for-byte.
> - Earlier v2 hardware testing covered keyboard-backlight control,
>   firmware brightness changes, s2idle, lid-close/open brightness
>   restoration, and EC wake events. Those results are historical and do
>   not establish validation of the complete v5 series or its revised PM
>   handling. No v5 build or runtime validation was performed while
>   preparing this submission directory.
> 

Nitpick: I assume your LLM added this bullet point(?), but for
submitting a series upstream this is kind of like "shooting yourself in
the foot". You haven't tested this series for 3 revisions and your LLM
hasn't even build-tested it? Please make sure you test your submissions. :-)

Thanks,
Stephan