Re: [PATCH v1 1/1] minix: consolidate itree* files into one itree.c file

[Christoph Hellwig]

On Mon, Sep 28, 2026 at 01:04:26PM -0700, Jeremy Bingham wrote:
> Consolidate the itree functions by adding fields to the superblock info
> struct to store the number of direct blocks and levels of indirect
> blocks because the different versions of the minix filesystems have
> differing numbers of indirect block pointers and different block pointer
> sizes. This allows consolidating the itree functions into one itree.c
> file instead of a system with version specific itree files with version
> specific definitions and wrapper functions that #include a common
> itree_common.c file that are in turn called by wrapper functions
> elsewhere in the code that call the version specific wrapper functions.
> 
> No functional changes are intended for this patch. 
> 
> Suggested-by: Christoph Hellwig <hch@xxxxxxxxxxxxx>
> Suggested-by: Darrick J. Wong <djwong@xxxxxxxxxx>
> Signed-off-by: Jeremy Bingham <jbingham@xxxxxxxxx>

Looks good from the high-level perspective:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

I assume you've run xfstests and checked nothing regresseѕ?