Re: [PATCH] docs: dmaengine: document ownership of the descriptor flags field
From: Vinod Koul
Date: Mon Oct 05 2026 - 11:50:39 EST
On Sat, 22 Aug 2026 03:15:30 +0300, Bogdan Mahomet wrote:
> The flags field of struct dma_async_tx_descriptor has carried a TODO
> since the provider documentation was added in 2014, asking whether a
> driver may modify the field itself or whether it must always hold the
> flags passed in the arguments.
>
> The field belongs to the client. dma_async_tx_descriptor_init() does
> not touch it, so the provider has to set it, and providers store the
> flags they were given verbatim; vchan_tx_prep() does this for every
> driver built on top of virt-dma. Afterwards providers only read the
> field: the DMA_PREP_* bits are consumed while the descriptor is being
> prepared, and DMA_CTRL_ACK and DMA_CTRL_REUSE are tested with
> async_tx_test_ack() and dmaengine_desc_test_reuse() before a
> descriptor is recycled or freed.
>
> [...]
Applied, thanks!
[1/1] docs: dmaengine: document ownership of the descriptor flags field
commit: ef399305a5bf64231059c63a53f3384eb59c2458
Best regards,
--
~Vinod