Re: [PATCH v4 4/6] platform/x86/tuxedo: Fix keyboard LED map ordering

[Aaron Erhardt]

Am 05.10.26 um 16:06 schrieb Ilpo Järvinen:
> On Mon, 28 Sep 2026, Aaron Erhardt wrote:
> 
>> The LED mappings in sirius_16_[iso|ansii]_kbl_map did contain a
>> flipped line that caused LEDs to turn on in the wrong order when
>> counting up the Lamp ID.
>>
>> Fixes: cfd84b3f419b
> 
> Please see Documentation/process/submitting-patches.rst how to format 
> the Fixes tag properly.
> 
> You seem to also have not carried over Werner's Reviewed-by tags to a new 
> version. Whenever you're submitting a new version of the series, collect 
> the tags given to the previous version. (Only if you've done very major
> changes to the patches, it may be warranted to not include tags given 
> earlier.)
> 
> Generally, maintainer tools will only pick tags for the current version of 
> the series (err'ing to the side of caution) which is why submitters are 
> expected to do that when a new version gets posted.
> 

I read that exact document, but only the lower section about when and not how.
Sorry for that. I'll fix both problems in the next series.

>> Cc: stable@xxxxxxxxxxxxxxx
>> Signed-off-by: Aaron Erhardt <aer@xxxxxxxxxxxxxxxxxxx>
>> ---
>>  drivers/platform/x86/tuxedo/nb04/wmi_ab.c | 8 ++++----
>>  1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/platform/x86/tuxedo/nb04/wmi_ab.c b/drivers/platform/x86/tuxedo/nb04/wmi_ab.c
>> index 8f1ffca0430d..2b985b030197 100644
>> --- a/drivers/platform/x86/tuxedo/nb04/wmi_ab.c
>> +++ b/drivers/platform/x86/tuxedo/nb04/wmi_ab.c
>> @@ -232,8 +232,8 @@ static const struct tux_kbl_map_entry_t sirius_16_ansii_kbl_map[] = {
>>  	{ 0x2e, { 246000,  67500, 5250 } },
>>  	{ 0x2a, { 269500,  67500, 5250 } },
>>  	{ 0x53, { 294500,  67500, 5250 } },
>> -	{ 0x55, { 311200,  67500, 5250 } },
>> -	{ 0x54, { 327900,  67500, 5250 } },
>> +	{ 0x54, { 311200,  67500, 5250 } },
>> +	{ 0x55, { 327900,  67500, 5250 } },
>>  	{ 0x56, { 344600,  67500, 5250 } },
>>  	{ 0x2b, {  31000,  85500, 5500 } },
>>  	{ 0x14, {  51500,  85500, 5500 } },
>> @@ -337,8 +337,8 @@ static const struct tux_kbl_map_entry_t sirius_16_iso_kbl_map[] = {
>>  	{ 0x2e, { 246000,  67500, 5250 } },
>>  	{ 0x2a, { 269500,  67500, 5250 } },
>>  	{ 0x53, { 294500,  67500, 5250 } },
>> -	{ 0x55, { 311200,  67500, 5250 } },
>> -	{ 0x54, { 327900,  67500, 5250 } },
>> +	{ 0x54, { 311200,  67500, 5250 } },
>> +	{ 0x55, { 327900,  67500, 5250 } },
>>  	{ 0x56, { 344600,  67500, 5250 } },
>>  	{ 0x2b, {  31000,  85500, 5500 } },
>>  	{ 0x14, {  51500,  85500, 5500 } },
>>
>