[PATCH] staging: iio: adt7316: use kstrtobool() for sysfs boolean parsing
From: Abdelnasser Hussein
Date: Tue Oct 06 2026 - 06:39:07 EST
Replace manual and unsafe character checks (e.g., buf[0] == '1') with the
standard kstrtobool() API in sysfs store functions. This ensures proper
handling of standard boolean inputs, fixes potential safety issues, and
adheres to the Linux kernel coding style.
Signed-off-by: Abdelnasser Hussein <abdelnasserhussein11@xxxxxxxxx>
---
drivers/staging/iio/addac/adt7316.c | 94 +++++++++++++++++++++++------
1 file changed, 77 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
index 20f6052cc7fb..21a1b811a142 100644
--- a/drivers/staging/iio/addac/adt7316.c
+++ b/drivers/staging/iio/addac/adt7316.c
@@ -246,12 +246,12 @@ static ssize_t adt7316_store_enabled(struct device *dev,
{
struct iio_dev *dev_info = dev_to_iio_dev(dev);
struct adt7316_chip_info *chip = iio_priv(dev_info);
- int enable;
+ bool enable;
+ int ret;
- if (buf[0] == '1')
- enable = 1;
- else
- enable = 0;
+ ret = kstrtobool(buf, &enable);
+ if (ret)
+ return ret;
if (_adt7316_store_enabled(chip, enable) < 0)
return -EIO;
@@ -285,13 +285,18 @@ static ssize_t adt7316_store_select_ex_temp(struct device *dev,
struct iio_dev *dev_info = dev_to_iio_dev(dev);
struct adt7316_chip_info *chip = iio_priv(dev_info);
u8 config1;
+ bool req;
int ret;
if ((chip->id & ID_FAMILY_MASK) != ID_ADT75XX)
return -EPERM;
+ ret = kstrtobool(buf, &req);
+ if (ret)
+ return ret;
+
config1 = chip->config1 & (~ADT7516_SEL_EX_TEMP);
- if (buf[0] == '1')
+ if (req)
config1 |= ADT7516_SEL_EX_TEMP;
ret = chip->bus.write(chip->bus.client, ADT7316_CONFIG1, config1);
@@ -482,10 +487,15 @@ static ssize_t adt7316_store_disable_averaging(struct device *dev,
struct iio_dev *dev_info = dev_to_iio_dev(dev);
struct adt7316_chip_info *chip = iio_priv(dev_info);
u8 config2;
+ bool req;
int ret;
+ ret = kstrtobool(buf, &req);
+ if (ret)
+ return ret;
+
config2 = chip->config2 & (~ADT7316_DISABLE_AVERAGING);
- if (buf[0] == '1')
+ if (req)
config2 |= ADT7316_DISABLE_AVERAGING;
ret = chip->bus.write(chip->bus.client, ADT7316_CONFIG2, config2);
@@ -521,10 +531,15 @@ static ssize_t adt7316_store_enable_smbus_timeout(struct device *dev,
struct iio_dev *dev_info = dev_to_iio_dev(dev);
struct adt7316_chip_info *chip = iio_priv(dev_info);
u8 config2;
+ bool req;
int ret;
+ ret = kstrtobool(buf, &req);
+ if (ret)
+ return ret;
+
config2 = chip->config2 & (~ADT7316_EN_SMBUS_TIMEOUT);
- if (buf[0] == '1')
+ if (req)
config2 |= ADT7316_EN_SMBUS_TIMEOUT;
ret = chip->bus.write(chip->bus.client, ADT7316_CONFIG2, config2);
@@ -559,10 +574,15 @@ static ssize_t adt7316_store_powerdown(struct device *dev,
struct iio_dev *dev_info = dev_to_iio_dev(dev);
struct adt7316_chip_info *chip = iio_priv(dev_info);
u8 config1;
+ bool req;
int ret;
+ ret = kstrtobool(buf, &req);
+ if (ret)
+ return ret;
+
config1 = chip->config1 & (~ADT7316_PD);
- if (buf[0] == '1')
+ if (req)
config1 |= ADT7316_PD;
ret = chip->bus.write(chip->bus.client, ADT7316_CONFIG1, config1);
@@ -597,10 +617,15 @@ static ssize_t adt7316_store_fast_ad_clock(struct device *dev,
struct iio_dev *dev_info = dev_to_iio_dev(dev);
struct adt7316_chip_info *chip = iio_priv(dev_info);
u8 config3;
+ bool req;
int ret;
+ ret = kstrtobool(buf, &req);
+ if (ret)
+ return ret;
+
config3 = chip->config3 & (~ADT7316_ADCLK_22_5);
- if (buf[0] == '1')
+ if (req)
config3 |= ADT7316_ADCLK_22_5;
ret = chip->bus.write(chip->bus.client, ADT7316_CONFIG3, config3);
@@ -640,13 +665,18 @@ static ssize_t adt7316_store_da_high_resolution(struct device *dev,
struct iio_dev *dev_info = dev_to_iio_dev(dev);
struct adt7316_chip_info *chip = iio_priv(dev_info);
u8 config3;
+ bool req;
int ret;
if (chip->id == ID_ADT7318 || chip->id == ID_ADT7519)
return -EPERM;
+ ret = kstrtobool(buf, &req);
+ if (ret)
+ return ret;
+
config3 = chip->config3 & (~ADT7316_DA_HIGH_RESOLUTION);
- if (buf[0] == '1')
+ if (req)
config3 |= ADT7316_DA_HIGH_RESOLUTION;
ret = chip->bus.write(chip->bus.client, ADT7316_CONFIG3, config3);
@@ -685,12 +715,17 @@ static ssize_t adt7316_store_AIN_internal_Vref(struct device *dev,
struct iio_dev *dev_info = dev_to_iio_dev(dev);
struct adt7316_chip_info *chip = iio_priv(dev_info);
u8 config3;
+ bool req;
int ret;
if ((chip->id & ID_FAMILY_MASK) != ID_ADT75XX)
return -EPERM;
- if (buf[0] != '1')
+ ret = kstrtobool(buf, &req);
+ if (ret)
+ return ret;
+
+ if (!req)
config3 = chip->config3 & (~ADT7516_AIN_IN_VREF);
else
config3 = chip->config3 | ADT7516_AIN_IN_VREF;
@@ -728,10 +763,15 @@ static ssize_t adt7316_store_enable_prop_DACA(struct device *dev,
struct iio_dev *dev_info = dev_to_iio_dev(dev);
struct adt7316_chip_info *chip = iio_priv(dev_info);
u8 config3;
+ bool req;
int ret;
+ ret = kstrtobool(buf, &req);
+ if (ret)
+ return ret;
+
config3 = chip->config3 & (~ADT7316_EN_IN_TEMP_PROP_DACA);
- if (buf[0] == '1')
+ if (req)
config3 |= ADT7316_EN_IN_TEMP_PROP_DACA;
ret = chip->bus.write(chip->bus.client, ADT7316_CONFIG3, config3);
@@ -767,10 +807,15 @@ static ssize_t adt7316_store_enable_prop_DACB(struct device *dev,
struct iio_dev *dev_info = dev_to_iio_dev(dev);
struct adt7316_chip_info *chip = iio_priv(dev_info);
u8 config3;
+ bool req;
int ret;
+ ret = kstrtobool(buf, &req);
+ if (ret)
+ return ret;
+
config3 = chip->config3 & (~ADT7316_EN_EX_TEMP_PROP_DACB);
- if (buf[0] == '1')
+ if (req)
config3 |= ADT7316_EN_EX_TEMP_PROP_DACB;
ret = chip->bus.write(chip->bus.client, ADT7316_CONFIG3, config3);
@@ -967,10 +1012,15 @@ static ssize_t adt7316_store_DA_AB_Vref_bypass(struct device *dev,
struct iio_dev *dev_info = dev_to_iio_dev(dev);
struct adt7316_chip_info *chip = iio_priv(dev_info);
u8 dac_config;
+ bool req;
int ret;
+ ret = kstrtobool(buf, &req);
+ if (ret)
+ return ret;
+
dac_config = chip->dac_config & (~ADT7316_VREF_BYPASS_DAC_AB);
- if (buf[0] == '1')
+ if (req)
dac_config |= ADT7316_VREF_BYPASS_DAC_AB;
ret = chip->bus.write(chip->bus.client, ADT7316_DAC_CONFIG, dac_config);
@@ -1006,10 +1056,15 @@ static ssize_t adt7316_store_DA_CD_Vref_bypass(struct device *dev,
struct iio_dev *dev_info = dev_to_iio_dev(dev);
struct adt7316_chip_info *chip = iio_priv(dev_info);
u8 dac_config;
+ bool req;
int ret;
+ ret = kstrtobool(buf, &req);
+ if (ret)
+ return ret;
+
dac_config = chip->dac_config & (~ADT7316_VREF_BYPASS_DAC_CD);
- if (buf[0] == '1')
+ if (req)
dac_config |= ADT7316_VREF_BYPASS_DAC_CD;
ret = chip->bus.write(chip->bus.client, ADT7316_DAC_CONFIG, dac_config);
@@ -1969,10 +2024,15 @@ static ssize_t adt7316_set_int_enabled(struct device *dev,
struct iio_dev *dev_info = dev_to_iio_dev(dev);
struct adt7316_chip_info *chip = iio_priv(dev_info);
u8 config1;
+ bool req;
int ret;
+ ret = kstrtobool(buf, &req);
+ if (ret)
+ return ret;
+
config1 = chip->config1 & (~ADT7316_INT_EN);
- if (buf[0] == '1')
+ if (req)
config1 |= ADT7316_INT_EN;
ret = chip->bus.write(chip->bus.client, ADT7316_CONFIG1, config1);
--
2.54.0