Re: [PATCH v2 2/2] staging: rtl8723bs: replace uint with explicit types in rtw_security.c

[Greg KH]

On Wed, Oct 07, 2026 at 01:37:51AM +0530, Pranav Desai wrote:
> The non-standard 'uint' type was being used inconsistently for
> lengths, boolean flags, and computed values.
> 
> Replace 'uint' with explicit types based on their usage:
> - Change 'plen' to u32 in both aes_cipher and aes_decipher.
> - Change 'hdrlen' to u16 in aes_cipher to match struct pkt_attrib.
> - Change 'hdrlen' to u8 in aes_decipher to match struct rx_pkt_attrib.
> - Change 'qc_exists' and 'a4_exists' to bool as they are flags.
> - Change 'frtype' and 'frsubtype' to u8 because they are masked
>   down from 16-bit values and cannot exceed 8-bit values.
> - Change 'payload_remainder' to u8 because it is calculated as
>   (plen % 16), which guarantees a range of 0-15.
> - Change 'payload_index' to u32 because it indexes into the payload,
>   which is bounded by plen (u32).
> - Change 'num_blocks' to u32 since it is derived from 'plen' (u32).
> - Change 'len' and 'ori_len' in rtw_BIP_verify to u32 since they are
>   compute values derived from pattrib->pkt_len.
> - Change generic loop iterators (i, j) to unsigned int.
> - Update helper functions (construct_mic_iv, construct_mic_header1,
>   etc.) to match these new explicit parameter types.

Each one of these should be an individual patch, right?

thanks,

greg k-h