Re: [PATCH v2 1/2] staging: rtl8723bs: replace uint with u32 in hal_intf.[ch]

[Greg KH]

On Wed, Oct 07, 2026 at 01:37:50AM +0530, Pranav Desai wrote:
> The non-standard 'uint' type was used for the return values of
> rtw_hal_init() and rtw_hal_deinit(), as well as their internal
> 'status' variables.
> 
> Since the underlying hardware-specific functions
> (rtl8723bs_hal_init() and rtl8723bs_hal_deinit()) explicitly
> return u32, replace these 'uint' occurrences with 'u32' to match
> the underlying types and conform to the kernel coding style.
> 
> Signed-off-by: Pranav Desai <contact.pranavdesai@xxxxxxxxx>
> ---
>  drivers/staging/rtl8723bs/hal/hal_intf.c     | 8 ++++----
>  drivers/staging/rtl8723bs/include/hal_intf.h | 4 ++--
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl8723bs/hal/hal_intf.c
> index 1443875d1369..1290631a2158 100644
> --- a/drivers/staging/rtl8723bs/hal/hal_intf.c
> +++ b/drivers/staging/rtl8723bs/hal/hal_intf.c
> @@ -27,9 +27,9 @@ static void rtw_hal_init_opmode(struct adapter *padapter)
>  	rtw_setopmode_cmd(padapter, networkType, false);
>  }
>  
> -uint rtw_hal_init(struct adapter *padapter)
> +u32 rtw_hal_init(struct adapter *padapter)

That's very odd, shouldn't this be 'int' and return either 0 for
success, or -ERROR value for an error?

thanks,

greg k-h