[PATCH 05/13] pinctrl: qcom: lpass-lpi: Discard pm_runtime_put_autosuspend() return values
From: Brian Norris
Date: Tue Oct 06 2026 - 19:22:31 EST
Passing the pm_runtime_put_autosuspend() return value to callers is not
particularly useful.
Returning an error code from pm_runtime_put_autosuspend() merely means
that it has not queued up a timer or work item to check whether or not
the device can be suspended and there are many perfectly valid
situations in which that can happen, like after writing "on" to the
device's runtime PM "control" attribute in sysfs for one example.
Accordingly, update the LPASS LPI pinctrl driver to simply discard the
return value of pm_runtime_put_autosuspend() and return 0 to the
callers.
This will facilitate a planned change of the
pm_runtime_put_autosuspend() return type to void in the future, similar
to commit 3afd8df02433 ("PM: runtime: Change pm_runtime_put() return
type to void").
Signed-off-by: Brian Norris <briannorris@xxxxxxxxxxxx>
---
This patch is independent of the rest of the series, except for the end
(changing the return type). I expect it can be applied by individual
maintainers, and we pick up the end once the dust is settled.
drivers/pinctrl/qcom/pinctrl-lpass-lpi.c | 16 ++++++++++++----
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c
index 5fd4a4eba654..b93f661c36e5 100644
--- a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c
+++ b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c
@@ -76,7 +76,9 @@ static int lpi_gpio_read(struct lpi_pinctrl *state, unsigned int pin,
lpi_gpio_read_reg(state, pin, addr, val);
- return pm_runtime_put_autosuspend(state->dev);
+ pm_runtime_put_autosuspend(state->dev);
+
+ return 0;
}
static const struct pinctrl_ops lpi_gpio_pinctrl_ops = {
@@ -164,7 +166,9 @@ static int lpi_gpio_set_mux(struct pinctrl_dev *pctldev, unsigned int function,
u32p_replace_bits(&val, i, LPI_GPIO_FUNCTION_MASK);
lpi_gpio_write_reg(pctrl, pin, LPI_GPIO_CFG_REG, val);
- return pm_runtime_put_autosuspend(pctrl->dev);
+ pm_runtime_put_autosuspend(pctrl->dev);
+
+ return 0;
}
static const struct pinmux_ops lpi_gpio_pinmux_ops = {
@@ -261,7 +265,9 @@ static int lpi_config_set_slew_rate(struct lpi_pinctrl *pctrl,
mutex_unlock(&pctrl->lock);
- return pm_runtime_put_autosuspend(pctrl->dev);
+ pm_runtime_put_autosuspend(pctrl->dev);
+
+ return 0;
}
static int lpi_config_set(struct pinctrl_dev *pctldev, unsigned int group,
@@ -335,7 +341,9 @@ static int lpi_config_set(struct pinctrl_dev *pctldev, unsigned int group,
lpi_gpio_write_reg(pctrl, group, LPI_GPIO_CFG_REG, val);
- return pm_runtime_put_autosuspend(pctrl->dev);
+ pm_runtime_put_autosuspend(pctrl->dev);
+
+ return 0;
}
static const struct pinconf_ops lpi_gpio_pinconf_ops = {
--
2.56.0.360.g66cac248cb-goog