Re: [PATCH net-next v4 1/3] dinghai: add firmware version check and RISC-V readiness polling

[Jakub Kicinski]

On Mon, 28 Sep 2026 20:24:27 +0800 (CST) han.junyang@xxxxxxxxxx wrote:
> +struct zxdh_fw_compat {
> +	u8 module_id;
> +	u8 major;
> +	u8 fw_minor;
> +	u8 drv_minor;
> +	u16 patch;
> +	u16 rsv;
> +} __packed;

Why is this __packed? Please don't sprinkle packed annotations
unnecessarily, they lower code efficiency.

TBH the AI review for this patch looks like all false positives / nit
picks. We do trust PCIe devices a little. The AI review on patch 2
seems to have found real bugs.