Re: [PATCH net 1/2] net: cpsw: unregister secondary netdev on probe failure

From: Jakub Kicinski

Date: Tue Oct 06 2026 - 20:57:59 EST


On Sat, 3 Oct 2026 16:09:14 +0200 Karl Mehltretter wrote:
> + bool secondary_registered = false;

the rule of thumb is that error unwind should match the remove()
If not possible match the condition of the code, don't add local vars

Sashiko is right to suggest to fold the two fixes together.
--
pw-bot: cr