Re: [PATCH v2 5/7] s390/pci: Add error cleanup in zpci_directed_irq_init
From: Tobias Schumacher
Date: Wed Oct 07 2026 - 02:10:26 EST
On Tue Oct 6, 2026 at 9:19 PM CEST, Niklas Schnelle wrote:
> On Mon, 2026-10-05 at 14:03 +0200, Tobias Schumacher wrote:
>> If per-CPU airq_iv allocation fails in the loop, previously allocated
>> vectors and arrays leak. Add proper error path to release all resources
>> on failure.
>>
>> Fixes: e979ce7bced2 ("s390/pci: provide support for CPU directed interrupts")
>> Signed-off-by: Tobias Schumacher <ts@xxxxxxxxxxxxx>
>
> Had my bot review my reviews and it noticed that this is missing Cc
> stable despite having a Fixes tag.
Yes, this was intentional. The leak only happens if an allocation fails
during boot, which would make PCI unusable anyway, so I didn't think it
qualifies for stable. But I wouldn't mind adding Cc: stable if you
prefer.
Thanks,
Tobias