Re: [PATCH 04/45] dt-bindings: media: qcom,sm8250-camss: add pixel path variant

From: Gjorgji Rosikopulos (Consultant)

Date: Wed Oct 07 2026 - 06:07:31 EST


Hi Bryan,

On 10/7/2026 12:52 PM, Bryan O'Donoghue wrote:
> On 07/10/2026 00:39,
> Gjorgji.Rosikopulos.gjorgji.rosikopulos@xxxxxxxxxxxxxxxx wrote:
>> From: Atanas Filipov <atanas.filipov@xxxxxxxxxxxxxxxx>
>>
>> Document the qcom,sm8250pix-camss compatible for CAMSS configurations
>> that use the IFE pixel path. It uses the existing CAMSS property
>> layout without additional properties.
>>
>> Signed-off-by: Atanas Filipov <atanas.filipov@xxxxxxxxxxxxxxxx>
>> ---
>> .../devicetree/bindings/media/qcom,sm8250-camss.yaml | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml
>> index a509d4bbcb4a..d561179be48c 100644
>> --- a/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml
>> +++ b/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml
>> @@ -14,7 +14,9 @@ description: |
>>
>> properties:
>> compatible:
>> - const: qcom,sm8250-camss
>> + enum:
>> + - qcom,sm8250-camss
>> + - qcom,sm8250pix-camss
>>
>> clocks:
>> minItems: 37
>
> Same feed back as on the other binding.
>
> Enabling the PIX path shouldn't require a new compat string -
> Lanai/sm8650 operates this way and x1e/x2e will also follow this format
> in v2, v3.

I agree, maybe pix should always be enabled, hope userspace not break because
topology will have more outputs. Not sure how to handle this case for backward
compatibility. In theory if userspace apps are well written they should just work.

As an option do you think that camss-ife can be migrated to camss-pix and connected
the pix sub-device just for pixel pipeline?

~Gjorgji