Re: [PATCH v2 1/2] dmaengine: dw-edma: Sort Register Field Macros by Bit Position

[Verma, Devendra]

On 05-Oct-26 19:49, Vinod Koul wrote:
> On 17-09-26, 16:00, Devendra K Verma wrote:
> > Sort register field macros by bit position to improve readability.
> > No functional change.
>
> This fails on current code and needs a bit more sorting.

I will sort it out and resend the patch after re-basing.
Thank you!

-Devendra

> > Signed-off-by: Devendra K Verma <devverma@xxxxxxx>
> > ---
> > Changes in v1:
> >     o Corrected heading and body as per reviewer's suggestion
> > ---
> >   drivers/dma/dw-edma/dw-edma-pcie.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c
> > index 9f237ba916de..006dea7d6322 100644
> > --- a/drivers/dma/dw-edma/dw-edma-pcie.c
> > +++ b/drivers/dma/dw-edma/dw-edma-pcie.c
> > @@ -31,8 +31,8 @@
> >   
> >   #define DW_PCIE_XILINX_MDB_VSEC_DMA_ID		0x6
> >   #define DW_PCIE_XILINX_MDB_VSEC_ID		0x20
> > -#define DW_PCIE_XILINX_MDB_VSEC_DMA_BAR		GENMASK(10, 8)
> >   #define DW_PCIE_XILINX_MDB_VSEC_DMA_MAP		GENMASK(2, 0)
> > +#define DW_PCIE_XILINX_MDB_VSEC_DMA_BAR		GENMASK(10, 8)
> >   #define DW_PCIE_XILINX_MDB_VSEC_DMA_WR_CH	GENMASK(9, 0)
> >   #define DW_PCIE_XILINX_MDB_VSEC_DMA_RD_CH	GENMASK(25, 16)
> >   
> > --
> > 2.43.0