Re: [PATCH v3 1/2] dt-bindings: misc: qcom,fastrpc: Allow hex digits in compute-cb node names

[Ekansh Gupta]

On 07-10-2026 13:55, Mukesh Ojha wrote:
> On Tue, Oct 06, 2026 at 03:56:06PM +0530, Ekansh Gupta wrote:
>> The patternProperties key for compute-cb subnodes used [0-9]* which
>> only matches decimal digits. However, per DTS convention, node unit
>> addresses must be the lowercase hexadecimal representation of the reg
>> value. For compute-cb nodes with reg values >= 10 (e.g. 12, 13, 14),
>> the correct node names are compute-cb@c, compute-cb@d, compute-cb@e
>> respectively, which are not matched by the current pattern.
>>
>> Extend the pattern to [0-9a-f]* to allow lowercase hex digits, making
>> it consistent with DTS unit address conventions.
>>
>> Signed-off-by: Ekansh Gupta <ekansh.gupta@xxxxxxxxxxxxxxxx>
> 
> Reviewed-by: Mukesh Ojha <mukesh.ojha@xxxxxxxxxxxxxxxx>
> 
>> ---
>>  Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml
>> index 49d2a5e8ba39..14fed91fee50 100644
>> --- a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml
>> +++ b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml
>> @@ -79,7 +79,7 @@ properties:
>>      const: 0
>>  
>>  patternProperties:
>> -  "(compute-)?cb@[0-9]*$":
>> +  "(compute-)?cb@[0-9a-f]*$":
> 
> 
> While you are changing this, original change had * which allows
> cb@ as well ? should we make it to "(compute-)?cb@[0-9a-f]+$":
ack, this looks better, thanks>
> 
>>      type: object
>>  
>>      description: >
>>
>> -- 
>> 2.34.1
>>
>