Re: [PATCH v5 6/6] phy: qcom: snps-femto-v2: Add IPQ9650 support

[kernel test robot]

Hi Varadarajan,

kernel test robot noticed the following build errors:

[auto build test ERROR on 15551282e82db772bfc862f96a8abf14a60f4ea5]

url:    https://github.com/intel-lab-lkp/linux/commits/Varadarajan-Narayanan/dt-bindings-phy-qcom-qmp-usb-Add-IPQ9650-USB3-PHY/20261006-105915
base:   15551282e82db772bfc862f96a8abf14a60f4ea5
patch link:    https://lore.kernel.org/r/20261006-phy-v5-6-cbe9330a6449%40oss.qualcomm.com
patch subject: [PATCH v5 6/6] phy: qcom: snps-femto-v2: Add IPQ9650 support
config: i386-buildonly-randconfig-1003-20261007 (https://download.01.org/0day-ci/archive/20261007/202610071946.Z4D9aPGU-lkp@xxxxxxxxx/config)
compiler: gcc-13 (Debian 13.3.0-16) 13.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261007/202610071946.Z4D9aPGU-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202610071946.Z4D9aPGU-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

>> drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c:39:49: error: implicit declaration of function 'FIELD_PREP_CONST' [-Werror=implicit-function-declaration]
      39 | #define FSEL_24MHZ                              FIELD_PREP_CONST(FSEL_MASK, 2)
         |                                                 ^~~~~~~~~~~~~~~~
   drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c:449:60: note: in expansion of macro 'FSEL_24MHZ'
     449 |         { USB2_PHY_USB_PHY_HS_PHY_CTRL_COMMON0, FSEL_MASK, FSEL_24MHZ },
         |                                                            ^~~~~~~~~~
>> drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c:39:49: error: initializer element is not constant
      39 | #define FSEL_24MHZ                              FIELD_PREP_CONST(FSEL_MASK, 2)
         |                                                 ^~~~~~~~~~~~~~~~
   drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c:449:60: note: in expansion of macro 'FSEL_24MHZ'
     449 |         { USB2_PHY_USB_PHY_HS_PHY_CTRL_COMMON0, FSEL_MASK, FSEL_24MHZ },
         |                                                            ^~~~~~~~~~
   drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c:39:49: note: (near initialization for 'hs_6nm_phy_pre_tuning[3].val')
      39 | #define FSEL_24MHZ                              FIELD_PREP_CONST(FSEL_MASK, 2)
         |                                                 ^~~~~~~~~~~~~~~~
   drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c:449:60: note: in expansion of macro 'FSEL_24MHZ'
     449 |         { USB2_PHY_USB_PHY_HS_PHY_CTRL_COMMON0, FSEL_MASK, FSEL_24MHZ },
         |                                                            ^~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/FIELD_PREP_CONST +39 drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c

    33	
    34	#define USB2_PHY_USB_PHY_HS_PHY_CTRL_COMMON0	(0x54)
    35	#define SIDDQ					BIT(2)
    36	#define RETENABLEN				BIT(3)
    37	#define FSEL_MASK				GENMASK(6, 4)
    38	#define FSEL_DEFAULT				(0x3 << 4)
  > 39	#define FSEL_24MHZ				FIELD_PREP_CONST(FSEL_MASK, 2)
    40	#define VATESTENB_MASK				GENMASK(1, 0)
    41	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki