Re: [PATCH v2 0/4] ASoC: mediatek: Handle constraint return value in FE startup

From: Cezary Rojewski

Date: Wed Oct 07 2026 - 10:06:08 EST


On 10/7/2026 1:08 PM, phucduc.bui@xxxxxxxxx wrote:
> From: bui duc phuc <phucduc.bui@xxxxxxxxx>
>
> Hi all,
>
> Some FE startup callbacks may return a positive value from constraint
> helpers, but ASoC expects 0 on success. This can cause .shutdown() to be
> skipped during rollback.
>
> Return 0 explicitly on success.
>
> Compile-tested only.
>
> Changes in v2:
> - Rename the patch subject.
> - Simplify the code change as suggested by Cezary.
Thank you for the update. The snd_pcm_hw_constraint_xxx() finding is a
good catch.

Reviewed-by: Cezary Rojewski <cezary.rojewski@xxxxxxxxx>