Re: [PATCH 1/1] net: ethernet: micrel: ks8842: use dmaengine_submit() instead of ->tx_submit()
From: Vinod Koul
Date: Wed Oct 07 2026 - 11:15:40 EST
On 07-10-26, 15:43, Simon Horman wrote:
> On Fri, Oct 02, 2026 at 03:30:19PM -0400, Frank.Li@xxxxxxxxxxx wrote:
> > From: Frank Li <Frank.Li@xxxxxxx>
> >
> > Replace direct dma_async_tx_descriptor->tx_submit() calls with the
> > proper dmaengine_submit() API wrapper.
> >
> > Assisted-by: LLM
> > Signed-off-by: Frank Li <Frank.Li@xxxxxxx>
>
> Hi Frank,
>
> Is there a back-story to this change?
> Is it part of something larger?
Yep, Frank has been fixing direct calls with wrappers with aim to
eventually start moving dmaengine guts internal and have a good
consumer/provider split of the engine and objects
> In face value it looks like a cleanup to an unmaintained driver.
> And if so, I'm not sure it's worth the churn.
--
~Vinod