Re: [PATCH RESEND] phy: broadcom: ns2-usbdrd: cancel delayed work
From: Manivannan Sadhasivam
Date: Wed Oct 07 2026 - 12:01:34 EST
On Tue, Jul 28, 2026 at 09:34:18PM +0800, Hongyan Xu wrote:
> ns2_drd_phy_probe() initializes wq_extcon. Both GPIO IRQs and the probe
> tail can queue it. There is no remove hook, so the delayed work can run
> after driver-managed resources are being released.
>
> Add a managed cleanup action before requesting IRQs. Devres releases the
> IRQs first, then cancels the delayed work while extcon, GPIO and MMIO
> state is still valid.
>
> This issue was found by a static analysis tool.
>
> Signed-off-by: Hongyan Xu <getshell@xxxxxxxxxx>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxxxxxxxx>
- Mani
--
மணிவண்ணன் சதாசிவம்