Re: [PATCH v3 1/2] dt-bindings: leds: Add CZ.NIC Turris 1.x LED controller

[Rob Herring (Arm)]

On Mon, 28 Sep 2026 13:19:06 +0200, Josef Schlehofer wrote:
> From: Pali Rohár <pali@xxxxxxxxxx>
> 
> Add a binding for the LED controller on the front panel of the CZ.NIC
> Turris 1.x routers. The LEDs are controlled by the firmware of the
> CZ.NIC CPLD, which is memory mapped on the local bus.
> 
> The turris1x.dts device tree, which is part of the mainline kernel since
> v6.0, already references this compatible string.
> 
> Signed-off-by: Pali Rohár <pali@xxxxxxxxxx>
> Cc: Marek Behún <kabel@xxxxxxxxxx>
> Co-developed-by: Josef Schlehofer <pepe.schlehofer@xxxxxxxxx>
> Signed-off-by: Josef Schlehofer <pepe.schlehofer@xxxxxxxxx>
> ---
> 
> Notes:
>     Changes in v3, by Josef Schlehofer:
>     - drop the file name and "binding" from the subject
>     - describe the hardware rather than the driver
>     - fix example indentation and use the merged turris1x.dts node
>     - set Josef Schlehofer as the binding maintainer
>     - constrain color to LED_COLOR_ID_RGB
>     - list the required controller and LED properties
>     - describe the register range and the LED order in the reg properties,
>       and put the SPDX expression in parentheses
>     - pass dt_binding_check with dtschema 2026.9
> 
>     checkpatch asks whether MAINTAINERS needs updating for the new file.
>     The MAINTAINERS entry that covers it is added in 2/2, together with
>     the driver.
> 
>  .../bindings/leds/cznic,turris1x-leds.yaml    | 132 ++++++++++++++++++
>  1 file changed, 132 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/leds/cznic,turris1x-leds.yaml
> 

Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx>