Re: [PATCH net-next 4/8] net: dsa: realtek: rtl8365mb: set RGMII mode for family D

[Andrew Lunn]

> +#define RTL8365MB_D_REG_EXT_TXC_DLY				0x13f9
> +#define   RTL8365MB_D_EXT1_RGMII_TX_DLY_MASK			GENMASK(5, 3)

The current code looks at tx-internal-delay-ps and
rx-internal-delay-ps and programs some other registers. It is not
clear to me that the code you are adding here is correct when combined
with the current code. Please could you look at the delay
configuration.

    Andrew