Re: [PATCH net-next v3] net: mctp: Make flow KUnit coverage an explicit opt-in

[Jakub Kicinski]

On Fri,  2 Oct 2026 23:20:58 +0200 Karl Mehltretter wrote:
> MCTP_TEST selects MCTP_FLOWS, so KUNIT_ALL_TESTS builds flow support and
> SKB_EXTENSIONS even when no transport needs them. KUnit's style guide
> says tests should not select otherwise unused functionality. The CRC
> and crypto library tests use explicit ENABLE_ALL_FOR_KUNIT options for
> full coverage.
> 
> Remove the selection from MCTP_TEST. The core suite remains available
> without flows; its two flow cases use their existing skip paths. Add
> MCTP_ENABLE_ALL_FOR_KUNIT to opt into full coverage, and enable it in
> all_tests.config and a dedicated net/mctp/.kunitconfig. Both profiles
> run the flow cases without a hardware transport.
> 
> A plain MCTP_TEST=y configuration without the opt-in now skips those
> two cases. This is the coverage cost of leaving otherwise unused flow
> support disabled.
> 
> Assisted-by: LLM
> Signed-off-by: Karl Mehltretter <kmehltretter@xxxxxxxxx>
> ---
> Changes in v3:
> - Keep the core suite available without MCTP_FLOWS; a plain MCTP_TEST=y
>   configuration now skips only the two flow cases.
> - Add MCTP_ENABLE_ALL_FOR_KUNIT to retain full coverage in
>   all_tests.config and a focused net/mctp/.kunitconfig.
> - Drop the Fixes tag because this changes test configuration rather
>   than fixing a runtime MCTP bug.
> 
> v2: https://lore.kernel.org/r/20260928205352.30502-1-kmehltretter@xxxxxxxxx/
> v1: https://lore.kernel.org/r/20260925192510.93840-1-kmehltretter@xxxxxxxxx/
> 
> Validation: The MCTP KUnit suites were built with GCC 15.2 and booted
> under QEMU 10.2.1 on an isolated source export from net-next
> 014d795c7383, with the changed Kconfig files copied from 071876fd5048.
> Without the opt-in, mctp-sock passed 5/5 tests and mctp-route passed
> 21/23 tests with two expected flow-case skips. With the opt-in, both
> suites passed all 5 and 23 tests, respectively. On the full
> 071876fd5048 tree, the new net/mctp/.kunitconfig resolves all requested
> symbols and selects MCTP_FLOWS and SKB_EXTENSIONS.

I don't think this is worth applying
-- 
pw-bot: reject