Re: [PATCH 1/3] dt-bindings: power: spacemit: Add power domain controller

[Yixun Lan]

Hi Rob,

On 13:30 Mon 28 Sep     , Rob Herring wrote:
> On Fri, Sep 18, 2026 at 02:40:13AM +0000, Yixun Lan wrote:
> > Add initial power domain driver support for SpacemiT K1/K3 SoC, The Power
> > Domain Controller is SoC internal module which is part of APMU (Advanced
> > Power Management Unit), it is responsible for managing power across multi
> > power domains, which includes power on/off, isolation, power-on sequence.
> > 
> > Signed-off-by: Yixun Lan <dlan@xxxxxxxxxx>
> > ---
> >  .../bindings/power/spacemit,power-controller.yaml  | 43 ++++++++++++++++++++++
> >  include/dt-bindings/power/spacemit,k1-power.h      | 14 +++++++
> >  include/dt-bindings/power/spacemit,k3-power.h      | 12 ++++++
> >  3 files changed, 69 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/power/spacemit,power-controller.yaml b/Documentation/devicetree/bindings/power/spacemit,power-controller.yaml
> > new file mode 100644
> > index 000000000000..f869285f84da
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/power/spacemit,power-controller.yaml
> > @@ -0,0 +1,43 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/power/spacemit,power-controller.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: SpacemiT Power Domains Controller
> > +
> > +maintainers:
> > +  - Yixun Lan <dlan@xxxxxxxxxx>
> > +
> > +description: |
> > +  SpacemiT processors include support for multiple power domains which can be
> > +  powered on/off by software based on different application scenes to save power.
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - spacemit,k1-power-controller
> > +      - spacemit,k3-power-controller
> > +
> > +  '#power-domain-cells':
> > +    const: 1
> > +
> > +  spacemit,apmu:
> > +    $ref: /schemas/types.yaml#/definitions/phandle
> > +    description:
> > +      A phandle to APMU syscon to control registers for power domain
> 
> Sounds like the APMU should be the power-domain provider directly. You 
> don't seem to have any other registers for this node.
> 
em, you right, I will convert this patch to auxiliary driver which will
make this dt-binding doc obsolete

-- 
Yixun Lan (dlan)