Re:Re: [PATCH net v4] net: macb: rate limit netdev error info print in the data path

[taozj888]

Hi Theo:


Please see my comments inline.


Thanks,


Zijin Tao





At 2026-10-07 17:33:03, "Théo Lebrun" <theo.lebrun@xxxxxxxxxxx> wrote:
>Hello taozj888,
>
>I was reviewing your patch but you sent V4 at the same time!
>
>On Wed Oct 7, 2026 at 7:32 AM CEST,  wrote:
>> From: taozijin <taozj888@xxxxxxx>
>
>We need full names in kernel patches, you have that in your
>Signed-off-by.
>
>> Now the MACB ethernet driver print the netdev error information
>> directly by netdev_err(), which would lead to a large number of
>> error information print if there was a significant number of
>> error or just jumbo packets exceeding the MTU received when booting.
>> For example, it would print a large number of:
>>
>> macb PHYT0036:00 eth0: not whole frame pointed by descriptor
>> macb PHYT0036:00 eth0: not whole frame pointed by descriptor
>> ...
>>
>> in gem_rx() by received a large number of packets without
>> RX_EOF flag set, especially with unknown packet
>> type that would penetrate the hardware offload for the IP packets.
>>
>> The unlimited prints here would greatly bother and delay
>> the system booting process unless the source stop sending
>> packets since they occupy the console output bandwidth and
>> other processes have to wait for the completion of printing those
>> messages.
>>
>> So rate limit the netdev error information print in the receive
>> and transmit data path.
>>
>> Fixes: 89e5785fc8a6 ("[PATCH] Atmel MACB ethernet driver")
>> Cc: stable@xxxxxxxxxxxxxxx
>
>What happened? This doesn't match your discussion with Nicolai.

>https://lore.kernel.org/netdev/3e1515e162d084e2200eeaa6074bfbaf@xxxxxxxxxxx/


@Theo, in the link that you provided, Nicolai suggested to use the commit id 
"4df95131ea80", and the original text is quoted below:
"

>>>> Fixes: 89e5785fc8a6 ("[PATCH] Atmel MACB ethernet driver")
>>> 
>>> IMHO the correct tag is 4df95131ea80 ("net/macb: change RX path for
>>> GEM")?
>>> At least the gem_rx() messages were introduced here.
>> 
>> The patch used to touch macb_start_xmit(), which explains why I told
>> Zijin to target the initial commit on previous revision.
>> 
> OK, I will still use the initial commit indicated by Theo.

Please re-read Théo's reply: he only suggested the initial
because v1 also touched macb_start_xmit(). v2 doesn't anymore,
89e5785fc8a6 is no longer the right target. Please use:

Fixes: 4df95131ea80 ("net/macb: change RX path for GEM")
"
So I changed the commit id from "89e5785fc8a6" to "4df95131ea80"
in the v4 patch, and somebody suggested to set the changelog just
in the patch below its "---" part if there is only just 1 patch, but
not in the cover-letter, so I added the changlog in the v4 patch.


If you didn't agree the changes in the v4 patch I would like to just abandon
it, or I will send a v5 patch to restore to the contents of the v3 patch with
the changelog added in the patch itself.


For the autorship, I would like to use the "Zijin Tao <taozj888@xxxxxxx>" for all
parts in the patch (for the signed-off-by and From).

>
>TLDR, because those threads are a mess:
> - why drop start_xmit diff?
> - fix your patch autorship
> - check your changelog!
> - check your fixes!
>
>Thanks,
>
>--
>Théo Lebrun, Bootlin
>Embedded Linux and Kernel engineering
>https://bootlin.com