Re: [PATCH v9 3/5] platform/x86: bitland-mifs-wmi: Add Redmi mic-mute key entries

[Anton Karasev]

Hi Mingyou,

> - 0x00002101 (Fn-lock disabled state)
> - 0x00012101 (Fn-lock enabled state)

These are mic mute states, not Fn Lock ones. On the Redmi Book Pro 16
2024 (TM2309), EV20 puts the new mic state from the EC field MIUT into
the third byte, 0 for muted and 1 for unmuted, and Nika's report [1]
has 0x00002101 as muted and 0x00012101 as unmuted. In a test of v9 on
this machine, F4 gave KEY_MICMUTE with exactly these two payloads, so
the entries are right for these Xiaomi machines; only the commit
message needs the change.

> +	{ KE_KEY,    BI_HOTKEY_CODE(0x21, 0, 0), { KEY_MICMUTE } },
> +	{ KE_KEY,    BI_HOTKEY_CODE(0x21, 1, 0), { KEY_MICMUTE } },

Note that 0x21 is WMI_EVENT_WIN_KEY_LOCK in this driver's own enum.
Does your machine send 0x00002101 / 0x00012101 for the Win key lock? If
so, it would now report KEY_MICMUTE there.

[1] https://lore.kernel.org/all/20260531123345.237521-1-nika@xxxxxxxxxxxx/

Thanks,
Anton Karasev