Re: r8152: RX stops until rebind after -EPROTO on the bulk-in endpoint

[Dane Linssen]

> You could try it. We may consider increasing retries in mainline if
> this turns out to solve real world problems. Though so far, in the only
> reported case of 3 retries not working, 10 retries over a span of 100ms
> weren't helping either...

Thanks, I'd like to try it. It needs some setup here first (signed
modules), so it may take a while before I can report back.

> Any results yet?

Yes: three more stalls on the same host in 11 days (09-30, 10-04,
10-06), all with virt_state 0x40, each recovered by the watchdog's
rebind in about 30 s. Dynamic debug was on for the last two. Both
start with a single burst, and in the 11 days there wasn't one
"Transfer error" on ep 2 outside the stalls. 10-04:

  22:36:09.251 Transfer error for slot 4 ep 2 on endpoint
  22:36:09.252 Soft-reset ep 2, slot 4
  22:36:09.255 Transfer error for slot 4 ep 2 on endpoint
  22:36:09.255 Soft-reset ep 2, slot 4
  22:36:09.258 Transfer error for slot 4 ep 2 on endpoint
  22:36:09.259 Soft-reset ep 2, slot 4
  22:36:09.262 Transfer error for slot 4 ep 2 on endpoint
  22:36:09.262 Soft-reset ep 2, slot 4
  22:36:09.265 Transfer error for slot 4 ep 2 on endpoint
  22:36:09.266 Hard-reset ep 2, slot 4

>From there it's Transfer error + Hard-reset pairs at about 275/s
until the rebind 40 s later. 10-06 is the same: four soft retries
about 3.5 ms apart, the hard reset at +15 ms, then the same loop. So
here all the retries are spent within 15 ms.

usbmon, 2 s from each of the three stalls: every bulk-in (0x81)
completion is -71 (571, 553 and 551 of them), none succeed, and
bulk-out and the interrupt endpoint complete normally.

The other host with the same adapter logged no transfer errors at all
in the same 11 days.

Dane