Re: [PATCH 1/2] sparc32: remove redundant memset in arch_mm_preinit()

[Andreas Larsson]

On 2026-08-27 16:54, Sang-Heon Jeon wrote:
> memblock_alloc() returns zeroed memory, so the memset after the
> allocation is redundant.
> 
> No functional change.
> 
> Signed-off-by: Sang-Heon Jeon <ekffu200098@xxxxxxxxx>
> ---
>  arch/sparc/mm/init_32.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/sparc/mm/init_32.c b/arch/sparc/mm/init_32.c
> index e0e66f91ceeb..b4f31d41d665 100644
> --- a/arch/sparc/mm/init_32.c
> +++ b/arch/sparc/mm/init_32.c
> @@ -255,7 +255,6 @@ void __init arch_mm_preinit(void)
>  		prom_printf("mem_init: Cannot alloc valid_addr_bitmap.\n");
>  		prom_halt();
>  	}
> -	memset(sparc_valid_addr_bitmap, 0, i << 2);
>  
>  	taint_real_pages();
>  }

No need for this anymore as this code is gone on my for-next thanks to
commit 91c897e01883 ("sparc32: drop unused valid address bitmap").

Cheers,
Andreas