Re: [PATCH net-next v9 03/11] net: ethernet: oa_tc6: Move oa_tc6.c to its own directory

[netdev-bot+sashiko]

Thank you for your contribution! Sashiko AI review found 1 potential
issue(s) to consider.

Critical: 0 · High: 0 · Medium: 1 · Low: 0

If you believe none of the issues are legitimate, please reply to each
issue of Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply
(one such reply per series is enough).

- [Medium] The commit message presents this as a pure file move ("Move
  oa_tc6.c to its own directory", similarity index 100%), but the patch…

--

net: ethernet: oa_tc6: Move oa_tc6.c to its own directory

This patch moves drivers/net/ethernet/oa_tc6.c into a new
drivers/net/ethernet/oa_tc6/ directory, which gets its own Kconfig and
Makefile. It prepares for the hardware timestamping and PTP files that
come later in the series.

> diff --git a/drivers/net/ethernet/Makefile b/drivers/net/ethernet/Makefile
> index a306dae23bcb8..e0e86c249e425 100644
> --- a/drivers/net/ethernet/Makefile
> +++ b/drivers/net/ethernet/Makefile

[ ... ]

> @@ -105,5 +106,4 @@ obj-$(CONFIG_NET_VENDOR_XILINX) += xilinx/
>  obj-$(CONFIG_NET_VENDOR_XIRCOM) += xircom/
>  obj-$(CONFIG_NET_VENDOR_SYNOPSYS) += synopsys/
>  obj-$(CONFIG_NET_VENDOR_PENSANDO) += pensando/
> -obj-$(CONFIG_OA_TC6) += oa_tc6.o
>  obj-$(CONFIG_NET_VENDOR_ZTE) += zte/

[ ... ]

> diff --git a/drivers/net/ethernet/oa_tc6/Makefile b/drivers/net/ethernet/oa_tc6/Makefile
> new file mode 100644
> index 0000000000000..f24aae852ef27
> --- /dev/null
> +++ b/drivers/net/ethernet/oa_tc6/Makefile
> @@ -0,0 +1,7 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +#
> +# Makefile for OA TC6 10BASE-T1x MAC-PHY
> +#
> +
> +obj-$(CONFIG_OA_TC6) := oa_tc6_mod.o
> +oa_tc6_mod-objs := oa_tc6.o

[Severity: Medium]
Does this change the name of the module? Before this patch, the parent
Makefile had:

  obj-$(CONFIG_OA_TC6) += oa_tc6.o

That built oa_tc6.ko. With the composite target here, CONFIG_OA_TC6=m
builds oa_tc6_mod.ko instead, and KBUILD_MODNAME becomes "oa_tc6_mod".

The subject says "Move oa_tc6.c to its own directory", and the file
rename shows similarity index 100%. Neither the commit message nor the
changelog mentions the module rename, and nothing else in the tree uses
the new name.

Anything that refers to the module by name would stop matching. That
includes "modprobe oa_tc6" and "rmmod oa_tc6", modprobe.d blacklist or
options entries, /sys/module/oa_tc6, and module lists in initramfs or
packaging. Dependent drivers like lan865x still load it automatically,
because depmod resolves the dependency through exported symbols.

The new name also stays in place at the end of the series:

  oa_tc6_mod-objs := oa_tc6.o oa_tc6_ptp.o oa_tc6_tstamp.o

Is the rename needed? kbuild only rejects a composite module that has the
same name as one of its own objects.

At this commit there is only one object, so a plain
"obj-$(CONFIG_OA_TC6) += oa_tc6.o" in the subdirectory would keep
oa_tc6.ko.

After the other files are added, renaming the source file would also keep
the old module name. For example, oa_tc6.c could become oa_tc6_core.c,
with:

  oa_tc6-y := oa_tc6_core.o oa_tc6_ptp.o oa_tc6_tstamp.o

If the rename is intended, could the commit message say so?

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261009-s2500-mac-phy-support-v9-0-dcefe1d0bf0d%40onsemi.com