Re: [PATCH] tpm: clean up error checking in setup_ring()

From: Markus Elfring

Date: Sun Oct 11 2026 - 05:30:42 EST


> The bind_evtchn_to_irqhandler() function can never return 0.
…

I suggest to reconsider information once more also according to the probability
of return values from such a function.
https://elixir.bootlin.com/linux/v7.3-rc6/source/drivers/xen/events/events_base.c#L1453-L1461

bind_evtchn_to_irqhandler_chip()
https://elixir.bootlin.com/linux/v7.3-rc6/source/drivers/xen/events/events_base.c#L1432-L1451


…
> ---
> From static analysis. Untested.
>
> drivers/char/tpm/xen-tpmfront.c | 2 +-
…

Would you be looking for further collateral evolution?
https://elixir.bootlin.com/linux/v7.3-rc6/source/drivers/char/tpm/xen-tpmfront.c#L267-L272

Regards,
Markus