Re: [PATCH] sched/eevdf: Fix vprot across reweighting

[Kayra Cizmeci]

Hi Christian,

> > Currently in reweighting, while a tasks vruntime changes dead protection
> > could go alive, or alive protection could decrease, increase and go dead.
> > 
> > To fix this, implement rel_vprot similar to rel_deadline. Only

> Ah nice find, please allow me to look at this code for a bit if that's
> the best way to implement this, will review then, for now

> Tested-by: Christian Loehle <christian.loehle@xxxxxxx>

Thanks for testing! And yeah, take your time. 

> > major difference is that rel_vprot is not dependent on
> > PLACE_REL_DEADLINE, because there are no mechanisms (unlike deadline)
> > that recalculate vprot. So it gets carried.
> > 
> > Fixes: 80390ead2080 ("sched/fair: Separate se->vlag from se->vprot")
> > Fixes: bcd74b2ffdd0 ("sched/fair: Only set slice protection at pick time")
> > Link: https://lore.kernel.org/all/20261001164609.244156-1-kayracizmeci@xxxxxxxxx/
> > Link: https://lore.kernel.org/all/e4700a93-ebd5-4c7e-88b5-d606437a13c0@xxxxxxx/
> > Co-developed-by: Christian Loehle <christian.loehle@xxxxxxx>
> > Signed-off-by: Christian Loehle <christian.loehle@xxxxxxx>

> FWIW my SOB shouldn't be there anymore.

Right. I'll remove it on v2 aside with Co-developed-by.

Thanks!
Kayra