Re: [PATCH 7.2 000/428] 7.2.10-rc1 review

[Greg KH]

On Sun, Oct 11, 2026 at 01:13:12PM +0200, Miguel Ojeda wrote:
> On Fri, 09 Oct 2026 16:05:37 +0200 Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > This is the start of the stable review cycle for the 7.2.10 release.
> > There are 428 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Sun, 11 Oct 2026 14:08:23 +0000.
> > Anything received after that time might be too late.
> 
> Building Rust Binder breaks with:
> 
>     error[E0061]: this method takes 1 argument but 2 arguments were supplied
>        --> drivers/android/binder/node/wrapper.rs:86:50
>         |
>     86  |                 _drop_outside_lock = owner_inner.push_work(&node.owner, node2);
>         |                                                  ^^^^^^^^^ ----------- unexpected argument #1 of type `&Arc<Process>`
>         |
>     note: method defined here
>        --> drivers/android/binder/process.rs:173:19
>         |
>     173 |     pub(crate) fn push_work(
>         |                   ^^^^^^^^^
>     174 |         &mut self,
>     175 |         work: DLArc<dyn DeliverToRead>,
>         |         ------------------------------
>     help: remove the extra argument
>         |
>     86  -                 _drop_outside_lock = owner_inner.push_work(&node.owner, node2);
>     86  +                 _drop_outside_lock = owner_inner.push_work(node2);
>         |
> 
> (and similarly in `drivers/android/binder/node.rs:74`).
> 
> It is due to upstream commit:
> 
>   dbb17c9ea756 ("rust_binder: move (e)poll wait queue to Process")
> 
> which added a `&Process` parameter to `push_work`.
> 
> 6.8.y breaks similarly.
> 
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: Arve Hjønnevåg <arve@xxxxxxxxxxx>
> Cc: Todd Kjos <tkjos@xxxxxxxxxxx>
> Cc: Christian Brauner <christian@xxxxxxxxxx>
> Cc: Carlos Llamas <cmllamas@xxxxxxxxxx>
> Cc: Alice Ryhl <aliceryhl@xxxxxxxxxx>

Seems to be broken by "rust_binder: reschedule node refcount update on
thread exit" as removing that fixes the builds which I did.  Any
objection to that?

thanks,

greg k-h