Re: [PATCH net v1] net: devmem: prevent mixing fragments from different bindings
From: Mina Almasry
Date: Sun Oct 11 2026 - 12:01:46 EST
On Sun, Oct 11, 2026 at 8:00 AM <netdev-bot+sashiko@xxxxxxxxxx> wrote:
>
> Thank you for your contribution! Sashiko AI review found 2 potential
> issue(s) to consider.
>
> Critical: 0 · High: 2 (1) · Medium: 0 · Low: 0
>
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
>
> - [High] This patch makes a valid devmem MSG_ZEROCOPY sendmsg() fail with
> -EFAULT.
> - [High] The commit says it prevents mixing fragments from different
> devmem bindings in one skb, but it only guards the…
>
> Pre-existing issues:
> - [High] This problem wasn't introduced by this patch, but it undermines
> the validation the patch hardens.
>
Both these issues seem valid. I could fix them in follow up patches
but it may be good to try to fix them now. Let me take a stab at it.
pw-bot: cr
--
Thanks,
Mina