[PATCH v10 5/5] platform/x86: bitland-mifs-wmi: Add quirks table
From: Mingyou Chen
Date: Sun Oct 11 2026 - 12:26:33 EST
The MIFS WMI interface is shared by several Bitland ODM laptops which
differ in the layout of the performance mode values of
WMI_FN_SYSTEM_PER_MODE and in the capability checks.
Introduce a quirks table to support multiple machine families without
sprinkling model checks over the driver.
Signed-off-by: Mingyou Chen <qby140326@xxxxxxxxx>
---
drivers/platform/x86/bitland-mifs-wmi.c | 137 ++++++++++++++++--------
1 file changed, 95 insertions(+), 42 deletions(-)
diff --git a/drivers/platform/x86/bitland-mifs-wmi.c b/drivers/platform/x86/bitland-mifs-wmi.c
index 93a519b96189..b3d615a94e8b 100644
--- a/drivers/platform/x86/bitland-mifs-wmi.c
+++ b/drivers/platform/x86/bitland-mifs-wmi.c
@@ -12,6 +12,7 @@
#include <linux/bits.h>
#include <linux/container_of.h>
#include <linux/dev_printk.h>
+#include <linux/dmi.h>
#include <linux/device.h>
#include <linux/device/devres.h>
#include <linux/err.h>
@@ -84,6 +85,60 @@ enum bitland_mifs_power_profile {
WMI_PP_FULL_SPEED = 3,
};
+struct bitland_mifs_wmi_data;
+
+/*
+ * Value layout of WMI_FN_SYSTEM_PER_MODE.
+ */
+struct bitland_profile_mode_map {
+ u8 balanced;
+ u8 performance;
+ u8 quiet;
+ u8 full_speed;
+};
+
+static const struct bitland_profile_mode_map bitland_mode_map = {
+ .balanced = WMI_PP_BALANCED,
+ .performance = WMI_PP_PERFORMANCE,
+ .quiet = WMI_PP_QUIET,
+ .full_speed = WMI_PP_FULL_SPEED,
+};
+
+struct bitland_profile_entry {
+ enum platform_profile_option profile;
+ u8 wmi_val;
+ bool no_set;
+};
+
+struct bitland_mifs_quirks {
+ const struct bitland_profile_entry *profile_entries;
+ size_t num_profile_entries;
+
+ bool return_code_at_end;
+ bool skip_ac_type_check;
+
+ /* Accept return value 0 on SET wmi functions */
+ bool accept_zero_function;
+};
+
+static const struct bitland_profile_entry default_profile_entries[] = {
+ { PLATFORM_PROFILE_LOW_POWER, WMI_PP_QUIET },
+ { PLATFORM_PROFILE_BALANCED, WMI_PP_BALANCED },
+ { PLATFORM_PROFILE_BALANCED_PERFORMANCE, WMI_PP_PERFORMANCE },
+ { PLATFORM_PROFILE_PERFORMANCE, WMI_PP_FULL_SPEED },
+};
+
+static const struct bitland_mifs_quirks default_quirks = {
+ .profile_entries = default_profile_entries,
+ .num_profile_entries = ARRAY_SIZE(default_profile_entries),
+};
+
+};
+
+static const struct dmi_system_id bitland_mifs_dmi_table[] = {
+ {}
+};
+
enum bitland_mifs_event_id {
WMI_EVENT_SWITCHVIDEOMODE = 1,
WMI_EVENT_SELECTIVE_SCREENSHOT = 2,
@@ -166,6 +221,7 @@ struct bitland_mifs_wmi_data {
struct input_dev *input_dev;
struct device *hwmon_dev;
struct device *pp_dev;
+ const struct bitland_mifs_quirks *quirks;
enum platform_profile_option saved_profile;
};
@@ -208,37 +264,30 @@ static int laptop_profile_get(struct device *dev,
enum platform_profile_option *profile)
{
struct bitland_mifs_wmi_data *data = dev_get_drvdata(dev);
+ const struct bitland_mifs_quirks *quirks = data->quirks;
struct bitland_mifs_input input = {
.operation = cpu_to_le16(WMI_METHOD_GET),
.function = cpu_to_le16(WMI_FN_SYSTEM_PER_MODE),
};
struct bitland_mifs_output result;
+ size_t i;
int ret;
ret = bitland_mifs_wmi_call(data, &input, &result);
if (ret)
return ret;
- switch (result.data[0]) {
- case WMI_PP_BALANCED:
- *profile = PLATFORM_PROFILE_BALANCED;
- break;
- case WMI_PP_PERFORMANCE:
- *profile = PLATFORM_PROFILE_BALANCED_PERFORMANCE;
- break;
- case WMI_PP_QUIET:
- *profile = PLATFORM_PROFILE_LOW_POWER;
- break;
- case WMI_PP_FULL_SPEED:
- *profile = PLATFORM_PROFILE_PERFORMANCE;
- break;
- default:
- return -EINVAL;
+ for (i = 0; i < quirks->num_profile_entries; i++) {
+ if (quirks->profile_entries[i].wmi_val == result.data[0]) {
+ *profile = quirks->profile_entries[i].profile;
+ return 0;
+ }
}
+
return 0;
}
-static int bitland_check_performance_capability(struct bitland_mifs_wmi_data *data)
+static int bitland_pp_check_capability(struct bitland_mifs_wmi_data *data)
{
struct bitland_mifs_input input = {
.operation = cpu_to_le16(WMI_METHOD_GET),
@@ -247,6 +296,9 @@ static int bitland_check_performance_capability(struct bitland_mifs_wmi_data *da
struct bitland_mifs_output output;
int ret;
+ if (data->quirks->skip_ac_type_check)
+ return power_supply_is_system_supplied() > 0 ? 0 : -EOPNOTSUPP;
+
/* Full-speed/performance mode requires DC power (not USB-C) */
if (!power_supply_is_system_supplied())
return -EOPNOTSUPP;
@@ -269,47 +321,42 @@ static int laptop_profile_set(struct device *dev,
enum platform_profile_option profile)
{
struct bitland_mifs_wmi_data *data = dev_get_drvdata(dev);
+ const struct bitland_mifs_quirks *quirks = data->quirks;
struct bitland_mifs_input input = {
.operation = cpu_to_le16(WMI_METHOD_SET),
.function = cpu_to_le16(WMI_FN_SYSTEM_PER_MODE),
};
+ size_t i;
int ret;
- u8 val;
- switch (profile) {
- case PLATFORM_PROFILE_LOW_POWER:
- val = WMI_PP_QUIET;
- break;
- case PLATFORM_PROFILE_BALANCED:
- val = WMI_PP_BALANCED;
- break;
- case PLATFORM_PROFILE_BALANCED_PERFORMANCE:
- ret = bitland_check_performance_capability(data);
+ if (profile == PLATFORM_PROFILE_PERFORMANCE ||
+ profile == PLATFORM_PROFILE_BALANCED_PERFORMANCE) {
+ ret = bitland_pp_check_capability(data);
if (ret)
return ret;
- val = WMI_PP_PERFORMANCE;
- break;
- case PLATFORM_PROFILE_PERFORMANCE:
- ret = bitland_check_performance_capability(data);
- if (ret)
- return ret;
- val = WMI_PP_FULL_SPEED;
- break;
- default:
- return -EOPNOTSUPP;
}
- input.payload[0] = val;
+ for (i = 0; i < quirks->num_profile_entries; i++) {
+ if (quirks->profile_entries[i].profile == profile &&
+ !quirks->profile_entries[i].no_set) {
+ input.payload[0] = quirks->profile_entries[i].wmi_val;
+ return bitland_mifs_wmi_call(data, &input, NULL);
+ }
+ }
- return bitland_mifs_wmi_call(data, &input, NULL);
+ return -EOPNOTSUPP;
}
static int platform_profile_probe(void *drvdata, unsigned long *choices)
{
- set_bit(PLATFORM_PROFILE_LOW_POWER, choices);
- set_bit(PLATFORM_PROFILE_BALANCED, choices);
- set_bit(PLATFORM_PROFILE_BALANCED_PERFORMANCE, choices);
- set_bit(PLATFORM_PROFILE_PERFORMANCE, choices);
+ struct bitland_mifs_wmi_data *data = drvdata;
+ const struct bitland_mifs_quirks *quirks = data->quirks;
+ size_t i;
+
+ for (i = 0; i < quirks->num_profile_entries; i++) {
+ if (!quirks->profile_entries[i].no_set)
+ set_bit(quirks->profile_entries[i].profile, choices);
+ }
return 0;
}
@@ -718,6 +765,7 @@ static int bitland_mifs_wmi_probe(struct wmi_device *wdev, const void *context)
.default_label = ":" LED_FUNCTION_KBD_BACKLIGHT,
.devname_mandatory = true,
};
+ const struct dmi_system_id *dmi_id;
int ret;
drv_data = devm_kzalloc(&wdev->dev, sizeof(*drv_data), GFP_KERNEL);
@@ -732,6 +780,11 @@ static int bitland_mifs_wmi_probe(struct wmi_device *wdev, const void *context)
dev_set_drvdata(&wdev->dev, drv_data);
+ drv_data->quirks = &default_quirks;
+ dmi_id = dmi_first_match(bitland_mifs_dmi_table);
+ if (dmi_id)
+ drv_data->quirks = dmi_id->driver_data;
+
if (dev_type == BITLAND_WMI_EVENT) {
/* Register input device for hotkeys */
drv_data->input_dev = devm_input_allocate_device(&wdev->dev);
--
2.55.0