Re: [PATCH v12 0/5] iio: pressure: dps310: hardware FIFO support

[Jonathan Cameron]

On Sat,  3 Oct 2026 22:50:06 +0300
Rupesh Majhi <zoone.rupert@xxxxxxxxx> wrote:

> Rest of FIFO series, on iio/togreg which has 1-6 and 10 of v8.
> 
> Since v11:
>  - patch 1: blank line, Reviewed-by Andy
>  - patch 2: guard() in postenable, setup moved to a helper that kfree()s
>    on error, scoped_guard() in fifo_work, loop counters in the for,
>    ternary on one line, two comments trimmed. The first loop in
>    fifo_drain keeps cnt outside, it is used after the loop.
>  - patch 3: signature wrapped
>  - patch 4: drain comment and commit message trimmed
>  - patch 5: Suggested-by Andy back, assert in the new helper too, still
>    optional
> 
> Pressure overflow fix is now at v4:
> https://lore.kernel.org/linux-iio/20261003185716.32732-1-zoone.rupert@xxxxxxxxx/
> Patches 1 and 5 conflict trivially with it. I can rebase on whichever
> goes in first.
> 
> Retested on DPS310 with BeagleBone Black. Lockdep run under QEMU.
> 
> v11: https://lore.kernel.org/linux-iio/20261002072526.250081-1-zoone.rupert@xxxxxxxxx/
> 
Applied patches 1-4.   Not this was messy so there was some hand applying needed.
Please check I didn't mess it up!
Maybe we'll still get some more review on these (which is fine as I'm fine tweaking
or dropping them until I rebase on rc1 in a few weeks time). 

However, too much in flight and I wanted to trim down what I was paying attention
to!

I replied with my view on patch 5 in the earlier thread (just now), but definitely
open to hearing more opinions on how far we want to go with annotations.

Thanks,

Jonathan

> Rupesh Majhi (5):
>   iio: pressure: dps310: use devm_mutex_init()
>   iio: pressure: dps310: read buffered samples from the hardware FIFO
>   iio: pressure: dps310: derive the drain interval from the watermark
>   iio: pressure: dps310: implement .hwfifo_flush_to_buffer()
>   iio: pressure: dps310: assert the lock at runtime too
> 
>  drivers/iio/pressure/dps310.c | 441 +++++++++++++++++++++++++++++++++-
>  1 file changed, 430 insertions(+), 11 deletions(-)
> 
> 
> base-commit: a3b3580713f3ac5a32dc2874ee546828977a1d68