Re: [PATCH v2] exit: fix lost-update race on the child_subreaper bitfields

[Oleg Nesterov]

On 10/11, Nickolai Zeldovich wrote:
>
> --- a/include/linux/sched/signal.h
> +++ b/include/linux/sched/signal.h
> @@ -130,8 +130,8 @@ struct signal_struct {
>  	 * process will inherit a flag if they should look for a
>  	 * child_subreaper process at exit.
>  	 */
> -	unsigned int		is_child_subreaper:1;
> -	unsigned int		has_child_subreaper:1;
> +	bool			is_child_subreaper;
> +	bool			has_child_subreaper;
>  	unsigned int		autoreap:1;

Thanks,

Acked-by: Oleg Nesterov <oleg@xxxxxxxxxx>

perhaps it makes sense to add something like signal_struct::atomic_flags
later...

Oleg.