Re: [PATCH v2 2/3] soc: mediatek: cmdq-helper: add legacy GCE ISA support

[Jassi Brar]

On Wed, Sep 9, 2026 at 4:57 AM AngeloGioacchino Del Regno
<angelogioacchino.delregno@xxxxxxxxxxxxx> wrote:
>
> On 9/7/26 20:03, Roman Vivchar via B4 Relay wrote:
> > From: Roman Vivchar <rva333@xxxxxxxxxxxxxx>
> >
> > Some SoCs, such as mt6572, have different WRITE and POLL instruction
> > encoding. Instead of 16-bit offset and 8-bit subsystem ID, old GCEs have
> > 22-bit offset and 2-bit subsystem ID.
> >
> > Extend cmdq_instruction struct with additional union and struct to hold
> > the legacy format of instruction encoding. Add legacy_isa to select
> > legacy GCE ISA when writing instruction. Finally, add special handing
> > for legacy_isa cases.
> >
> > Also correct comment about PA writes, because it's incorrect for legacy
> > ISA. Only v2 (mt8167, 8173) and v3 (mt8168, 6768, 6779, 6785, etc) have
> > GPRs and SPRs for PA writes.
> >
> > While mt6572 GCE supports 22-bit offsets, the parameter type for offset
> > remains 16 bit, because all mt6572 GCE mmsys consumers are in the 0xffff
> > range.
> >
> > Signed-off-by: Roman Vivchar <rva333@xxxxxxxxxxxxxx>
>
> Verified in the lab on multiple MediaTek boards.
>
> ... but I either need an ack on patch 3/3 from mailbox maintainers, or they need
> an ack from me on this patch to pick everything.
>
> I'm fine with anyone picking this, so...
>
> Acked-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
>
I realize the patch order is messed up - it should have been 1-3-2
instead. So maybe for this time...

Acked-by: Jassi Brar <jassisinghbrar@xxxxxxxxx>

Thanks
Jassi